-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zimuku.py does not handle archives with ZIP or RAR suffix, only handles zip or rar #2588
Comments
is it also possilble to handle 7zip archived subtitles? |
I'm unable to test but filename seems to be fine to cast to lowercase. Using:
Any help testing this would be appreciated @waterloo3122. Can you edit your file and replace the line 319 with the code i sent above. If the fix works, i will push to the As for 7zip archives, it has to be implemented and tested. But it seems possible to implement. Any help is appreciated. |
@waterloo3122 were you able to test this? |
No News, Good News! The issue will be applied and it will be fixed on the upcoming beta! |
Describe the bug
some subtitles from provider zimuku are suffixed with ZIP or RAR, not normally small cased zip or rar
logs:
2024-07-22 10:35:01,189 - subliminal_patch.providers.zimuku (7f28a286eb38) : DEBUG (zimuku:340) - Identified zip archive
2024-07-22 10:35:01,189 - subliminal_patch.providers.zimuku (7f28a286eb38) : DEBUG (zimuku:341) - Identified zip archive with filename attachment; filename="[zmk.pw]xxx.xxx.S02E01.1080p.AMZN.WEB-DL.DDP5.1.H.264-NTb.ZIP"
then download error occured
Expected behavior
should handle ZIP or RAR suffixed subtitle archives
Software (please complete the following information):
The text was updated successfully, but these errors were encountered: