fix remaining flake8 errors

Author: PetrDlouhy

ajax_datatable/__init__.py

@@ -1,18 +1,18 @@
 from __future__ import unicode_literals
 __version__ = '4.3.1'
 
-from .columns import (
+from .columns import (  # noqa
     Column,
     ForeignColumn,
     ColumnLink,
     PlaceholderColumnLink,
     Order,
 )
 
-from .exceptions import (
+from .exceptions import (  # noqa
     ColumnOrderError,
 )
 
-from .views import (
+from .views import (  # noqa
     AjaxDatatableView
 )

ajax_datatable/views.py

@@ -6,6 +6,7 @@
 import json
 from django.views.generic import View
 from django.http.response import HttpResponse, HttpResponseBadRequest
+from django.core.exceptions import FieldDoesNotExist
 from django.core.paginator import Paginator
 from django.core.serializers.json import DjangoJSONEncoder
 from django.db import models
@@ -143,7 +144,7 @@ def initialize(self, request):
                 else:
                     try:
                         title = self.model._meta.get_field(name).verbose_name.title()
-                    except AttributeError:
+                    except (AttributeError, FieldDoesNotExist):
                         title = name
 
                 column['name'] = name

example/backend/admin.py

@@ -1,6 +1,5 @@
 from django.contrib import admin
 from django.utils.safestring import mark_safe
-from django.utils.translation import ugettext_lazy as _
 from django.utils import timezone
 from .models import Tag
 from .models import Artist

example/backend/management/commands/fix_albums_release_date.py

@@ -8,12 +8,8 @@
 from django.db import transaction
 from django.db import connections
 from django.db import DEFAULT_DB_ALIAS
-from django.contrib import auth
-from django.contrib.auth import get_user_model
 from django.core.management.base import BaseCommand
-from backend.models import Artist
 from backend.models import Album
-from backend.models import Track
 
 MONTH_NAMES = [calendar.month_name[i] for i in range(1, 12+1)]
 
@@ -52,7 +48,7 @@ def fix_release_dates(self):
         albums = Album.objects.filter(year=None).exclude(url='')
         print(albums)
 
-        network = pylast.LastFMNetwork(
+        pylast.LastFMNetwork(
             api_key=settings.LASTFM_API_KEY,
             api_secret=settings.LASTFM_API_SECRET,
             username=settings.LASTFM_USERNAME,
@@ -110,7 +106,7 @@ def scrape_release_date(url):
                 day = int(tokens[-3])
         release_date = datetime.date(year, month, day)
         # print(release_date)
-    except Exception as e:
+    except Exception:
         release_date = None
 
     return release_date

example/backend/management/commands/load_from_lastfm.py

@@ -3,8 +3,6 @@
 from django.db import transaction
 from django.db import connections
 from django.db import DEFAULT_DB_ALIAS
-from django.contrib import auth
-from django.contrib.auth import get_user_model
 from django.core.management.base import BaseCommand
 from backend.models import Artist
 from backend.models import Album
@@ -98,7 +96,7 @@ def load_artist(self, artist, obj_artist):
                     try:
                         title = obj_track.get_title()
                         print('    %s' % title)
-                        track = Track.objects.create(
+                        Track.objects.create(
                             album=album,
                             name=title,
                         )

example/backend/models.py

@@ -1,5 +1,4 @@
 import uuid
-import os
 from django.db import models
 from django.urls import reverse
 from django.utils import timezone
@@ -107,7 +106,9 @@ def clone(self, request=None):
 
         obj = Track.objects.get(id=self.id)
         obj.pk = uuid.uuid4()
-        obj.description = increment_revision(self.description)
+        # TODO: this seems abandoned, Track has no field description and there is
+        # no function increment_revision
+        # obj.description = increment_revision(self.description)
         obj.save()
         return obj
 

example/frontend/ajax_datatable_views.py

@@ -1,29 +1,7 @@
-import json
-import datetime
-import sys
-import inspect
-#import dateutil.parser
 from django.contrib.auth import get_user_model
-from django.urls import reverse
-from django.shortcuts import render
-from django.contrib.auth.decorators import login_required
 from ajax_datatable.views import AjaxDatatableView
-from ajax_datatable.utils import trace
-from django.utils.decorators import method_decorator
-from django.http import JsonResponse
-from django.views.decorators.csrf import csrf_exempt
-from django.contrib.auth import get_user_model
 from django.utils.translation import ugettext_lazy as _
-from django.template import TemplateDoesNotExist
-from django.template.loader import render_to_string
-from django.db.models import Count, Min, Sum, Avg
-from django.utils.safestring import mark_safe
-from django.template import loader, Context
-from django.contrib.contenttypes.models import ContentType
-from django.contrib.humanize.templatetags.humanize import intcomma
-from django.template.defaultfilters import truncatechars
 from django.contrib.auth.models import Permission
-from django.db.models import Q
 
 from project.query_debugger import query_debugger
 from backend.models import Track
@@ -119,7 +97,7 @@ class TrackAjaxDatatableView(AjaxDatatableView):
         {'name': 'album', 'foreign_field': 'album__name', 'visible': True, 'lookup_field': '__istartswith', },
         {'name': 'artist', 'title': 'Artist', 'foreign_field': 'album__artist__name',
             'visible': True, 'choices': True, 'autofilter': True, },
-        #{'name': 'tags', 'visible': True, 'searchable': False, },
+        # {'name': 'tags', 'visible': True, 'searchable': False, },
         {'name': 'tags', 'm2m_foreign_field': 'tags__name', 'searchable': True, 'choices': True, 'autofilter': True, },
     ]
 
@@ -162,7 +140,7 @@ def get_initial_queryset(self, request=None):
         def get_numeric_param(key):
             try:
                 value = int(request.POST.get(key))
-            except:
+            except (ValueError, AttributeError):
                 value = None
             return value
 

example/frontend/urls.py

@@ -16,14 +16,16 @@
     path('tracks/', views.tracks_list_view, name="tracks-list"),
     path('ajax_datatable/tracks/', ajax_datatable_views.TrackAjaxDatatableView.as_view(), name="ajax_datatable_track"),
     path('ajax_datatable/album/', ajax_datatable_views.AlbumAjaxDatatableView.as_view(), name="ajax_datatable_album"),
-    path('ajax_datatable/artist/', ajax_datatable_views.ArtistAjaxDatatableView.as_view(), name="ajax_datatable_artist"),
+    path('ajax_datatable/artist/',
+         ajax_datatable_views.ArtistAjaxDatatableView.as_view(), name="ajax_datatable_artist"),
 
     path('ajax_datatable/permissions/', ajax_datatable_views.PermissionAjaxDatatableView.as_view(),
          name="ajax_datatable_permissions"),
     path('minimal/', TemplateView.as_view(template_name='frontend/minimal.html'), name="minimal"),
 
     path('custompks/', TemplateView.as_view(template_name='frontend/custompk/list.html'), name="custompks-list"),
-    path('ajax_datatable/custompks/', ajax_datatable_views.CustomPkAjaxDatatableView.as_view(), name="ajax_datatable_custompk"),
+    path('ajax_datatable/custompks/',
+         ajax_datatable_views.CustomPkAjaxDatatableView.as_view(), name="ajax_datatable_custompk"),
 
     path('side_filters/', TemplateView.as_view(template_name='frontend/side_filters.html'), name="side_filters"),
 ]

example/frontend/views.py

@@ -1,8 +1,7 @@
 from django.shortcuts import render
-from django.contrib.auth.decorators import login_required
 from django.contrib.auth import get_user_model
 from project.query_debugger import query_debugger
-from backend.models import Track
+# from backend.models import Track
 
 
 User = get_user_model()
@@ -14,7 +13,7 @@ def tracks_list_view(request):
     Render the page which contains the table.
     That will in turn invoke (via Ajax) object_datatable_view(), to fill the table content
     """
-    model = Track
+    # model = Track
     template_name = "frontend/track/list.html"
 
     return render(request, template_name, {

example/project/settings.py

@@ -19,13 +19,14 @@
 BASE_DIR = os.path.dirname(os.path.dirname(os.path.abspath(__file__)))
 
 # try:
-#     main.__build__ = subprocess.check_output(["git", "describe", "--tags", "--always"], cwd=BASE_DIR).decode('utf-8').strip()
+#     main.__build__ = subprocess.check_output(
+#        ["git", "describe", "--tags", "--always"], cwd=BASE_DIR).decode('utf-8').strip()
 # except:
 #     main.__build__ = main.__version__ + " ?"
 try:
     project.__build__ = subprocess.check_output(
         ["git", "describe", "--tags", "--always"], cwd=BASE_DIR).decode('utf-8').strip()
-except:
+except Exception:
     project.__build__ = ""
 
 print('build: %s' % project.__build__, file=sys.stderr)
@@ -39,7 +40,7 @@
 # SECURITY WARNING: don't run with debug turned on in production!
 DEBUG = True
 
-#ALLOWED_HOSTS = []
+# ALLOWED_HOSTS = []
 ALLOWED_HOSTS = ['*', ]
 
 
@@ -176,7 +177,7 @@
 
 # Load local settings when supplied
 try:
-    from project.local import *
+    from project.local import *  # noqa
     print('Local settings loaded !', file=sys.stderr)
-except ModuleNotFoundError as e:
+except ModuleNotFoundError:
     pass