Skip to content

Commit e60cedf

Browse files
committed
Merge branch 'PHP-7.1'
* PHP-7.1: Bugfix #74556 stream_socket_get_name() returns empty string Fix abstract name handling to be binary safe
2 parents 818272a + e628ee9 commit e60cedf

File tree

4 files changed

+30
-1
lines changed

4 files changed

+30
-1
lines changed

NEWS

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ PHP NEWS
5252
a fatal error). (pmmaga)
5353
. Fixed bug #63384 (Cannot override an abstract method with an abstract
5454
method). (pmmaga, wes)
55+
. Fixed misparsing of abstract unix domain socket names. (Sara)
5556

5657
- BCMath:
5758
. Fixed bug #46564 (bcmod truncates fractionals). (liborm85)
@@ -202,6 +203,7 @@ PHP NEWS
202203
. Fixed bug #72979 (money_format stores wrong length AIX). (matthieu.sarter)
203204
. Fixed bug #74300 (unserialize accepts two plus/minus signs for float number exponent part).
204205
(xKerman)
206+
. Fixed bug #74556 (stream_socket_get_name() returns '\0'). (Sara)
205207

206208
- XML:
207209
. Moved utf8_encode() and utf8_decode() to the Standard extension. (Andrea)

ext/standard/streamsfuncs.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -330,6 +330,11 @@ PHP_FUNCTION(stream_socket_get_name)
330330
RETURN_FALSE;
331331
}
332332

333+
if (!ZSTR_LEN(name)) {
334+
zend_string_release(name);
335+
RETURN_FALSE;
336+
}
337+
333338
RETVAL_STR(name);
334339
}
335340
/* }}} */
Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
--TEST--
2+
Bug #74556 stream_socket_get_name() on unix socket returns "\0"
3+
--SKIPIF--
4+
<?php
5+
if (!strncasecmp(PHP_OS, 'WIN', 3)) echo "skip Unix Only";
6+
--FILE--
7+
<?php
8+
9+
$sock = __DIR__ . '/bug74556.sock';
10+
$s = stream_socket_server("unix://$sock");
11+
$c = stream_socket_client("unix://$sock");
12+
13+
var_dump(
14+
stream_socket_get_name($s, true),
15+
stream_socket_get_name($c, false)
16+
);
17+
--CLEAN--
18+
<?php
19+
unlink(__DIR__ . '/bug74556.sock');
20+
--EXPECT--
21+
bool(false)
22+
bool(false)

main/network.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -649,7 +649,7 @@ PHPAPI void php_network_populate_name_from_sockaddr(
649649

650650
if (ua->sun_path[0] == '\0') {
651651
/* abstract name */
652-
int len = strlen(ua->sun_path + 1) + 1;
652+
int len = sl - sizeof(sa_family_t);
653653
*textaddr = zend_string_init((char*)ua->sun_path, len, 0);
654654
} else {
655655
int len = strlen(ua->sun_path);

0 commit comments

Comments
 (0)