Skip to content

Commit 2773f83

Browse files
authored
Merge pull request #15 from morganstanley/upload-docs
Include Javadocs in the uploaded build artifacts
2 parents 48aa209 + 2fb4feb commit 2773f83

File tree

4 files changed

+7
-1
lines changed

4 files changed

+7
-1
lines changed

.github/workflows/push.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,5 +35,6 @@ jobs:
3535
with:
3636
name: build-artifacts
3737
path: |
38+
build/docs/
3839
build/libs/
3940
build/reports/

.github/workflows/release.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ jobs:
3737
with:
3838
name: build-artifacts
3939
path: |
40+
build/docs/
4041
build/libs/
4142
build/reports/
4243
build/local-publish/

src/main/java/com/ms/gradle/application/ApplicationJar.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,7 @@ protected void configureArchiveDefaults() {
227227
// - Leave the default `archiveFileName` pattern intact
228228
// - Keep the defaults for `archiveAppendix`, `archiveVersion`, `archiveClassifier` and `archiveExtension`
229229
// - Override the default value of `archiveBaseName` if we can set something that is meaningful and unique
230-
// (e.g. in our `Bound` subclass), leave it untouched otherwise
230+
// (e.g. in our `Bound` subclass), but leave it untouched otherwise
231231
}
232232

233233
/**

src/main/java/com/ms/gradle/application/ApplicationName.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,10 @@
1313
*/
1414
@SuppressWarnings("PMD.ConstantsInInterface") // This approach is consistent with the rest of Gradle
1515
public interface ApplicationName extends Named {
16+
17+
/**
18+
* The {@link Attribute} instance to be used as the key for {@link ApplicationName} values.
19+
*/
1620
Attribute<ApplicationName> APPLICATION_NAME_ATTRIBUTE =
1721
Attribute.of("com.ms.gradle.application.name", ApplicationName.class);
1822
}

0 commit comments

Comments
 (0)