Fixed regression bug with POST file downloads not working in IE 6 or IE 7

johnculviner · johnculviner · commit d64451173215 · 2012-06-26T00:41:17.000-05:00
diff --git a/src/Scripts/jquery.fileDownload.js b/src/Scripts/jquery.fileDownload.js
@@ -128,9 +128,9 @@ $.extend({
             //the stock android browser straight up doesn't support file downloads initiated by non GET requests: http://code.google.com/p/android/issues/detail?id=1780
 
             if ($().dialog) {
-                $("<div>").html(settings.androidPostUnsupportedMessageHtml).dialog(settings.dialogOptions);              
+                $("<div>").html(settings.androidPostUnsupportedMessageHtml).dialog(settings.dialogOptions);
             } else {
-                alert(settings.androidPostUnsupportedMessageHtml);               
+                alert(settings.androidPostUnsupportedMessageHtml);
             }
 
             return;
@@ -247,7 +247,7 @@ $.extend({
                     if (!key) return;
                     var value = decodeURIComponent(kvp[1] || '');
 
-                    formInnerHtml += $("<input type='text'>").attr("name", key).attr("value", value).wrap("<p>").parent().html();
+                    formInnerHtml += '<input type="hidden" name="' + key + '" value="' + value + '" />';
                 });
             }
 
@@ -274,7 +274,7 @@ $.extend({
                     formDoc = getiframeDocument($iframe);
                 }
 
-                formDoc.write("<html><head></head><body><form style='display:none' method='" + settings.httpMethod + "' action='" + fileUrl + "'>" + formInnerHtml + "</form>" + settings.popupWindowTitle + "</body></html>");
+                formDoc.write("<html><head></head><body><form method='" + settings.httpMethod + "' action='" + fileUrl + "'>" + formInnerHtml + "</form>" + settings.popupWindowTitle + "</body></html>");
                 $form = $(formDoc).find('form');
             }
 

Original file line number	Diff line number	Diff line change
`@@ -128,9 +128,9 @@ $.extend({`
`128`	`128`	`//the stock android browser straight up doesn't support file downloads initiated by non GET requests: http://code.google.com/p/android/issues/detail?id=1780`
`129`	`129`
`130`	`130`	`if ($().dialog) {`
`131`		`- $("<div>").html(settings.androidPostUnsupportedMessageHtml).dialog(settings.dialogOptions);`
	`131`	`+ $("<div>").html(settings.androidPostUnsupportedMessageHtml).dialog(settings.dialogOptions);`
`132`	`132`	`} else {`
`133`		`- alert(settings.androidPostUnsupportedMessageHtml);`
	`133`	`+ alert(settings.androidPostUnsupportedMessageHtml);`
`134`	`134`	`}`
`135`	`135`
`136`	`136`	`return;`
`@@ -247,7 +247,7 @@ $.extend({`
`247`	`247`	`if (!key) return;`
`248`	`248`	`var value = decodeURIComponent(kvp[1] \|\| '');`
`249`	`249`
`250`		`- formInnerHtml += $("<input type='text'>").attr("name", key).attr("value", value).wrap("<p>").parent().html();`
	`250`	`+ formInnerHtml += '<input type="hidden" name="' + key + '" value="' + value + '" />';`
`251`	`251`	`});`
`252`	`252`	`}`
`253`	`253`
`@@ -274,7 +274,7 @@ $.extend({`
`274`	`274`	`formDoc = getiframeDocument($iframe);`
`275`	`275`	`}`
`276`	`276`
`277`		`- formDoc.write("<html><head></head><body><form style='display:none' method='" + settings.httpMethod + "' action='" + fileUrl + "'>" + formInnerHtml + "</form>" + settings.popupWindowTitle + "</body></html>");`
	`277`	`+ formDoc.write("<html><head></head><body><form method='" + settings.httpMethod + "' action='" + fileUrl + "'>" + formInnerHtml + "</form>" + settings.popupWindowTitle + "</body></html>");`
`278`	`278`	`$form = $(formDoc).find('form');`
`279`	`279`	`}`
`280`	`280`