Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Models Types don't reflect API doc #111

Open
diogonlucena opened this issue Mar 12, 2024 · 1 comment
Open

Models Types don't reflect API doc #111

diogonlucena opened this issue Mar 12, 2024 · 1 comment

Comments

@diogonlucena
Copy link

Hello. We've started working with moov SDK and seems that there are some fields specified in the API doc that don't exist in the SDK typing

example:
api doc for Retrieve Transfer: https://docs.moov.io/api/money-movement/transfers/get/
says that theres a field called "failureReason"
but typing doesn't have it: https://github.com/moovfinancial/moov-node/blob/main/lib/types/transfers.d.ts#L497

there are many other fields in the same situation:

  • moovFeeDetails
  • completedOn
  • createdOn
    • this seems to be a worst case situation as the type defines the "createdAt" which doesn't seems to exist
  • disputes
  • groupId

and many others.

Is there any plan to update the SDK?

should we be using the regular api with some other rest lib instead? thanks ^^

@engrpatel21
Copy link

engrpatel21 commented Mar 12, 2024

i want to add on to this for micro deposits, the API docs say that for PUT complete micro deposits, we should get

{
   status: "verified"
}

yet the corresponding SDK function returns a void

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants