Fixing a few minor issues

Author: InfernoJJ

database/database_test.go

@@ -1,16 +1,18 @@
 // Copyright 2020 The Moov Authors
 // Use of this source code is governed by an Apache License
 // license that can be found in the LICENSE file.
-package database
+package database_test
 
 import (
 	"errors"
 	"testing"
+
+	"github.com/moov-io/base/database"
 )
 
 func TestUniqueViolation(t *testing.T) {
 	err := errors.New(`problem upserting depository="282f6ffcd9ba5b029afbf2b739ee826e22d9df3b", userId="f25f48968da47ef1adb5b6531a1c2197295678ce": Error 1062: Duplicate entry '282f6ffcd9ba5b029afbf2b739ee826e22d9df3b' for key 'PRIMARY'`)
-	if !UniqueViolation(err) {
+	if !database.UniqueViolation(err) {
 		t.Error("should have matched unique violation")
 	}
 }

database/model_config_test.go

@@ -1,22 +1,23 @@
 // Copyright 2020 The Moov Authors
 // Use of this source code is governed by an Apache License
 // license that can be found in the LICENSE file.
-package database
+package database_test
 
 import (
 	"bytes"
 	"encoding/json"
 	"testing"
 
+	"github.com/moov-io/base/database"
 	"github.com/stretchr/testify/require"
 )
 
 func TestMySQLConfig(t *testing.T) {
-	cfg := &MySQLConfig{
+	cfg := &database.MySQLConfig{
 		Address:  "tcp(localhost:3306)",
 		User:     "app",
 		Password: "secret",
-		Connections: ConnectionsConfig{
+		Connections: database.ConnectionsConfig{
 			MaxOpen: 100,
 		},
 	}

database/mysql.go

@@ -101,9 +101,9 @@ func (my *mysql) Connect(ctx context.Context) (*sql.DB, error) {
 	db.SetMaxOpenConns(maxActiveMySQLConnections)
 
 	// Check out DB is up and working
-	// if err := db.Ping(); err != nil {
-	// 	return nil, err
-	// }
+	if err := db.Ping(); err != nil {
+		return nil, err
+	}
 
 	// Setup metrics after the database is setup
 	go func(db *sql.DB) {