Skip to content

Commit 4f01fb9

Browse files
authored
refactor: change duration for seconds in metrics (#51)
* refactor: change duration in seconds * refactor: deprecate exportFor and exportForOver
1 parent a41e8af commit 4f01fb9

File tree

3 files changed

+24
-7
lines changed

3 files changed

+24
-7
lines changed

src/GitLabHealth-Model-Analysis/GitMetricExporter.class.st

Lines changed: 18 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -150,16 +150,32 @@ GitMetricExporter >> entities: aCollection [
150150
{ #category : #exporting }
151151
GitMetricExporter >> exportFor: usersWithProjects [
152152

153-
self exportFor: usersWithProjects over: { Date. Week . Month . Year }.
153+
self
154+
deprecated: 'Use #exportInCSV instead'
155+
on: '03 Sept 2024'
156+
in:
157+
'Pharo-11.0.0+build.726.sha.aece1b5473acf3830a0e082c1bc3a15d4ff3522b (64 Bit)'.
158+
159+
self exportFor: usersWithProjects over: {
160+
Date.
161+
Week.
162+
Month.
163+
Year }
154164
]
155165

156166
{ #category : #exporting }
157167
GitMetricExporter >> exportFor: usersWithProjects over: aCollectionOfDateWeekMonthOrYear [
158168

169+
self
170+
deprecated: 'Use #exportInCSV instead'
171+
on: '03 Sept 2024'
172+
in:
173+
'Pharo-11.0.0+build.726.sha.aece1b5473acf3830a0e082c1bc3a15d4ff3522b (64 Bit)'.
174+
159175
entities ifNil: [
160176
self addEntitiesFromUserNamesAndProjects: usersWithProjects ].
161177

162-
self exportFor: aCollectionOfDateWeekMonthOrYear.
178+
self exportFor: aCollectionOfDateWeekMonthOrYear
163179
]
164180

165181
{ #category : #exporting }

src/GitLabHealth-Model-Analysis/MergeRequestDurationMetric.class.st

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ Class {
88
MergeRequestDurationMetric >> calculate [
99

1010
| groupedByDate gitAnalyzer mergeRequestsValidation filterGroups |
11-
userMergeRequests ifNil: [ self load ].
11+
userMergeRequests ifNil: [ self load ].
1212
groupedByDate := self setupGroupedDate.
1313

1414
userMergeRequests ifEmpty: [ ^ nil ].
@@ -47,13 +47,13 @@ MergeRequestDurationMetric >> calculate [
4747

4848
filterGroups at: assoc key put: sum / denominator ].
4949

50-
^ filterGroups average asDuration
50+
^ filterGroups average asSeconds
5151
]
5252

5353
{ #category : #accessing }
5454
MergeRequestDurationMetric >> description [
5555

56-
^ 'merge request duration'
56+
^ 'merge request duration (in seconds)'
5757
]
5858

5959
{ #category : #accessing }

src/GitLabHealth-Model-Analysis/TimeBetweenCommitMetric.class.st

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,9 @@ TimeBetweenCommitMetric >> calculate [
3333
(commits2 committed_date
3434
- commits1 committed_date)
3535
asSeconds ].
36+
3637

37-
differences average asDuration ].
38+
differences average asFloat ].
3839

3940
average := groupedByDate
4041
ifEmpty: [ nil ]
@@ -46,7 +47,7 @@ TimeBetweenCommitMetric >> calculate [
4647
{ #category : #accessing }
4748
TimeBetweenCommitMetric >> description [
4849

49-
^ 'average time between commits'
50+
^ 'average time between commits (in seconds)'
5051
]
5152

5253
{ #category : #accessing }

0 commit comments

Comments
 (0)