Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: Fix global bin detection on windows. #77

Merged
merged 3 commits into from
Oct 7, 2024

Conversation

sharpepd
Copy link
Contributor

@sharpepd sharpepd commented Oct 5, 2024

Update version to 0.13.1

Fix issue #1673

Update version to 0.13.1

issue #1673
@milesj milesj changed the title vscode extension: Find globalPath on windows new: Fix global bin detection on windows. Oct 6, 2024
@milesj
Copy link
Contributor

milesj commented Oct 6, 2024

@sharpepd Just need to fix the formatting. Can run yarn moon check --all to see the errors.

@sharpepd
Copy link
Contributor Author

sharpepd commented Oct 7, 2024

I am not very familiar with this toolchain, but locally, I am getting errors in eslint due to a extension "moon" not being available.

Oops! Something went wrong! :(
babel-preset:lint |
babel-preset:lint | ESLint: 8.57.0
babel-preset:lint |
babel-preset:lint | ESLint couldn't find the config "moon" to extend from. Please check that the name of the config is correct.
babel-preset:lint |
babel-preset:lint | The config "moon" was referenced from the config file in "[...]\moon_dev.eslintrc.js".

So I have made my best guess at the changes and pushed. Fingers crossed!

@milesj
Copy link
Contributor

milesj commented Oct 7, 2024

@sharpepd Hrmmm, maybe do a yarn install to ensure the deps are there?

@sharpepd
Copy link
Contributor Author

sharpepd commented Oct 7, 2024

@sharpepd Hrmmm, maybe do a yarn install to ensure the deps are there?

I did that and still no luck. I cannot see where this "moon" dependency is coming from. It is certainly not found "node_modules". I was kind of hoping that using the moon task for linting, would do the job for me without any further set-up.

I did manage to find the linting errors and apply the fixes. So I hope this time the checks go through.

@milesj
Copy link
Contributor

milesj commented Oct 7, 2024

Awesome, looks good.

@milesj milesj merged commit d03a78c into moonrepo:master Oct 7, 2024
3 checks passed
Copy link

github-actions bot commented Oct 7, 2024

Run report for d03a78cd (18)

Total time: 11.3s | Comparison time: 20.4s | Estimated savings: 9.1s (44.8% faster)

Action Time Status Info
🟩 SyncWorkspace 5.9ms Passed
🟩 SetupToolchain(node:18.20.4) 3.8s Passed
🟩 SyncProject(node, vscode-extension) 0.5ms Passed
🟩 InstallWorkspaceDeps(node:18.20.4) 0.9ms Passed
🟩 RunTask(vscode-extension:test) 2.7s Passed
🟩 RunTask(vscode-extension:build) 3.1s Passed
🟩 RunTask(vscode-extension:format) 3.3s Passed
🟩 RunTask(vscode-extension:typecheck) 2.9s Passed
🟩 RunTask(vscode-extension:lint) 7.4s Passed
Environment

OS: Linux
Matrix:

node-version = 18

Variables:

MOON_NODE_VERSION = 18.20.4
Touched files
packages/vscode-extension/package.json
packages/vscode-extension/src/workspace.ts

Copy link

github-actions bot commented Oct 7, 2024

Run report for d03a78cd (20)

Total time: 11.6s | Comparison time: 22.1s | Estimated savings: 10.6s (47.8% faster)

Action Time Status Info
🟩 SyncWorkspace 5.4ms Passed
🟩 SetupToolchain(node:20.18.0) 4.2s Passed
🟩 SyncProject(node, vscode-extension) 0.8ms Passed
🟩 InstallWorkspaceDeps(node:20.18.0) 1.6ms Passed
🟩 RunTask(vscode-extension:test) 3s Passed
🟩 RunTask(vscode-extension:build) 3.5s Passed
🟩 RunTask(vscode-extension:format) 2.1s Passed
🟩 RunTask(vscode-extension:typecheck) 5.2s Passed
🟩 RunTask(vscode-extension:lint) 7.4s Passed
Environment

OS: Linux
Matrix:

node-version = 20

Variables:

MOON_NODE_VERSION = 20.18.0
Touched files
packages/vscode-extension/package.json
packages/vscode-extension/src/workspace.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants