-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new: Fix global bin detection on windows. #77
new: Fix global bin detection on windows. #77
Conversation
Update version to 0.13.1 issue #1673
@sharpepd Just need to fix the formatting. Can run |
I am not very familiar with this toolchain, but locally, I am getting errors in eslint due to a extension "moon" not being available. Oops! Something went wrong! :( So I have made my best guess at the changes and pushed. Fingers crossed! |
@sharpepd Hrmmm, maybe do a |
I did that and still no luck. I cannot see where this "moon" dependency is coming from. It is certainly not found "node_modules". I was kind of hoping that using the moon task for linting, would do the job for me without any further set-up. I did manage to find the linting errors and apply the fixes. So I hope this time the checks go through. |
Awesome, looks good. |
Run report for d03a78cd
|
Action | Time | Status | Info | |
---|---|---|---|---|
🟩 | SyncWorkspace |
5.9ms | Passed | |
🟩 | SetupToolchain(node:18.20.4) |
3.8s | Passed | |
🟩 | SyncProject(node, vscode-extension) |
0.5ms | Passed | |
🟩 | InstallWorkspaceDeps(node:18.20.4) |
0.9ms | Passed | |
🟩 | RunTask(vscode-extension:test) |
2.7s | Passed | |
🟩 | RunTask(vscode-extension:build) |
3.1s | Passed | |
🟩 | RunTask(vscode-extension:format) |
3.3s | Passed | |
🟩 | RunTask(vscode-extension:typecheck) |
2.9s | Passed | |
🟩 | RunTask(vscode-extension:lint) |
7.4s | Passed |
Environment
OS: Linux
Matrix:
node-version = 18
Variables:
MOON_NODE_VERSION = 18.20.4
Touched files
packages/vscode-extension/package.json
packages/vscode-extension/src/workspace.ts
Run report for d03a78cd
|
Action | Time | Status | Info | |
---|---|---|---|---|
🟩 | SyncWorkspace |
5.4ms | Passed | |
🟩 | SetupToolchain(node:20.18.0) |
4.2s | Passed | |
🟩 | SyncProject(node, vscode-extension) |
0.8ms | Passed | |
🟩 | InstallWorkspaceDeps(node:20.18.0) |
1.6ms | Passed | |
🟩 | RunTask(vscode-extension:test) |
3s | Passed | |
🟩 | RunTask(vscode-extension:build) |
3.5s | Passed | |
🟩 | RunTask(vscode-extension:format) |
2.1s | Passed | |
🟩 | RunTask(vscode-extension:typecheck) |
5.2s | Passed | |
🟩 | RunTask(vscode-extension:lint) |
7.4s | Passed |
Environment
OS: Linux
Matrix:
node-version = 20
Variables:
MOON_NODE_VERSION = 20.18.0
Touched files
packages/vscode-extension/package.json
packages/vscode-extension/src/workspace.ts
Update version to 0.13.1
Fix issue #1673