Merge branch 'main' into pragma

Author: Yoorkin

.github/workflows/check.yml

@@ -116,53 +116,42 @@ jobs:
           moon fmt
           git diff
 
-  # coverage-check-bleeding:
-  #   runs-on: macos-14
-  #   continue-on-error: true
-  #   permissions: write-all
-  #     # contents: read
-  #     # issues: write
-  #     # pull-requests: write
-  #   steps:
-  #     - uses: actions/checkout@v4
-
-  #     - name: install
-  #       run: |
-  #         /bin/bash -c "$(curl -fsSL https://cli.moonbitlang.com/bleeding/mac_m1_moon_setup.sh)"
-  #         echo "$HOME/.moon/bin" >> $GITHUB_PATH
-
-  #     - name: moon test
-  #       run: moon test --enable-coverage
-
-  #     - name: moon_cove_report
-  #       run: moon_cove_report
-
-  #     - name: bisect_ppx report
-  #       run: |
-  #         bisect-ppx-report html
-  #         bisect-ppx-report summary > coverage_summary.txt
-  #         echo "coverage_summary=$(cat coverage_summary.txt)" >> $GITHUB_ENV
-
-  #     - name: upload coverage artifact
-  #       uses: actions/upload-artifact@v4
-  #       with:
-  #         name: code-coverage-report
-  #         path: _coverage
-
-  #     - name: Add coverage comment to PR
-  #       if: github.event_name == 'pull_request'
-  #       uses: actions/github-script@v7
-  #       with:
-  #         script: |
-  #           const coverageReportLink = `https://github.com/${process.env.GITHUB_REPOSITORY}/actions/runs/${process.env.GITHUB_RUN_ID}`;
-  #           const prNumber = context.payload.pull_request.number;
-  #           const summary = process.env.coverage_summary;
-  #           await github.rest.issues.createComment({
-  #             owner: context.repo.owner,
-  #             repo: context.repo.repo,
-  #             issue_number: prNumber,
-  #             body: `${summary}\nCoverage report: ${coverageReportLink}`
-  #           });
+  coverage-check-bleeding:
+    runs-on: macos-14
+    continue-on-error: true
+    permissions:
+      contents: read
+      issues: write
+      pull-requests: write
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: install
+        run: |
+          /bin/bash -c "$(curl -fsSL https://cli.moonbitlang.com/bleeding/mac_m1_moon_setup.sh)"
+          echo "$HOME/.moon/bin" >> $GITHUB_PATH
+
+      - name: moon test
+        run: moon test --enable-coverage
+
+      - name: moon_cove_report
+        run: moon_cove_report
+
+      - name: bisect_ppx report
+        run: |
+          bisect-ppx-report html
+          bisect-ppx-report summary > coverage_summary.txt
+          echo "coverage_summary=$(cat coverage_summary.txt)" >> $GITHUB_ENV
+          # Put the coverage report in the pipline output
+          cat coverage_summary.txt >> "$GITHUB_STEP_SUMMARY"
+          bisect-ppx-report coveralls coverage.json --service-name github --service-job-id $GITHUB_RUN_NUMBER
+
+      - name: upload to codecov
+        uses: codecov/codecov-action@v2
+        with:
+          file: coverage.json
+          flags: bisect-ppx
+          verbose: true
 
   typo-check:
     runs-on: ubuntu-latest

README.md

@@ -1,6 +1,6 @@
 # moonbitlang/core
 
-[![check](https://github.com/moonbitlang/core/actions/workflows/check.yml/badge.svg)](https://github.com/moonbitlang/core/actions/workflows/check.yml)
+[![check](https://github.com/moonbitlang/core/actions/workflows/check.yml/badge.svg)](https://github.com/moonbitlang/core/actions/workflows/check.yml) [![codecov](https://codecov.io/gh/moonbitlang/core/graph/badge.svg?token=HRJPS16ZP9)](https://codecov.io/gh/moonbitlang/core)
 
 moonbitlang/core is the standard library of the [MoonBit language](https://www.moonbitlang.com/). It is released alongside the compiler. You can view the documentation for the latest official release at <https://mooncakes.io/docs/#/moonbitlang/core/>. This repository serves as the development repository.
 

array/array.mbt

@@ -584,3 +584,8 @@ test "to_list" {
   let ls = [1, 2, 3, 4, 5].to_list()
   @assertion.assert_eq(ls, Cons(1, Cons(2, Cons(3, Cons(4, Cons(5, Nil))))))?
 }
+
+test "op_equal" {
+  inspect([1, 2] == [1], ~content="false")?
+  inspect(starts_with([1, 2, 3], [1, 3]), ~content="false")?
+}

assertion/assertion.mbt

@@ -71,11 +71,15 @@ test "assert_ne.eq" {
   }
 }
 
-pub fn assert_false(x : Bool, ~loc : SourceLoc = _) -> Result[Unit, String] {
-  if x == false {
-    Ok(())
+pub fn assert_false[T : Debug + @bool.Boolean](
+  x : T,
+  ~loc : SourceLoc = _
+) -> Result[Unit, String] {
+  if x.to_bool() {
+    let x = debug_string(x)
+    Err("FAILED:\(loc) `\(x)` is not false")
   } else {
-    Err("FAILED:\(loc)")
+    Ok(())
   }
 }
 
@@ -87,11 +91,15 @@ test "assert_false.true" {
   assert_ne(assert_false(true), Ok(()))?
 }
 
-pub fn assert_true(x : Bool, ~loc : SourceLoc = _) -> Result[Unit, String] {
-  if x {
+pub fn assert_true[T : Debug + @bool.Boolean](
+  x : T,
+  ~loc : SourceLoc = _
+) -> Result[Unit, String] {
+  if x.to_bool() {
     Ok(())
   } else {
-    Err("FAILED:\(loc)")
+    let x = debug_string(x)
+    Err("FAILED:\(loc): `\(x)` is not true")
   }
 }
 

assertion/moon.pkg.json

@@ -1,6 +1,7 @@
 {
     "import": [
         "moonbitlang/core/builtin",
+        "moonbitlang/core/bool",
         "moonbitlang/core/coverage"
     ]
 }

bool/bool.mbt

@@ -11,3 +11,11 @@
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
+
+pub trait Boolean {
+  to_bool(Self) -> Bool
+}
+
+pub fn Bool::to_bool(self : Bool) -> Bool {
+  self
+}

deque/deque.mbt

@@ -32,6 +32,16 @@ pub fn Deque::with_capacity[T](cap : Int) -> Deque[T] {
   Deque::{ buf: UninitializedArray::make(cap), len: 0, head: 0, tail: 0 }
 }
 
+test "with_capacity" {
+  let d : Deque[Int] = Deque::with_capacity(0)
+  @assertion.assert_eq(d.buf.length(), 0)?
+}
+
+test "with_capacity_non_zero" {
+  let d : Deque[Int] = Deque::with_capacity(10)
+  @assertion.assert_eq(d.buf.length(), 10)?
+}
+
 /// Creates a new deque from an array.
 pub fn Deque::from_array[T](arr : Array[T]) -> Deque[T] {
   let deq = Deque::{
@@ -138,6 +148,9 @@ test "front_and_back" {
   let dq = Deque::[1, 2, 3, 4, 5]
   @assertion.assert_eq(dq.back(), Some(5))?
   @assertion.assert_eq(dq.front(), Some(1))?
+  let dq: Deque[Int] = Deque::[]
+  @assertion.assert_eq(dq.back(), None)?
+  @assertion.assert_eq(dq.front(), None)?
 }
 
 /// Adds an element to the front of the deque.
@@ -260,6 +273,22 @@ test "push_and_pop" {
   @assertion.assert_eq(dq.length(), 6)?
   @assertion.assert_eq(dq.pop_back(), Some(8))?
   @assertion.assert_eq(dq.back(), Some(7))?
+
+  let dq = Deque::[1]
+  @assertion.assert_eq(dq.pop_front(), Some(1))?
+  @assertion.assert_eq(dq.pop_front(), None)?
+  @assertion.assert_eq(dq.pop_back(), None)?
+}
+
+test "push_realloc" {
+  let dq: Deque[Int] = Deque::with_capacity(0)
+  dq.push_front(1)
+  @assertion.assert_eq(dq.pop_front(), Some(1))?
+  @assertion.assert_true(dq.capacity() > 0)?
+  let dq: Deque[Int] = Deque::with_capacity(0)
+  dq.push_back(1)
+  @assertion.assert_eq(dq.pop_back(), Some(1))?
+  @assertion.assert_true(dq.capacity() > 0)?
 }
 
 /// Retrieves the element at the specified index from the deque.
@@ -282,7 +311,7 @@ pub fn op_get[T](self : Deque[T], index : Int) -> T {
   if self.head + index < self.buf.length() {
     self.buf[self.head + index]
   } else {
-    self.buf[index- self.head+1]
+    self.buf[(self.head + index) % self.buf.length()]
   }
 }
 
@@ -293,8 +322,9 @@ test "op_get" {
   @assertion.assert_eq(dq[2], 3)?
   @assertion.assert_eq(dq[3], 4)?
   @assertion.assert_eq(dq[4], 5)?
+  let _ = dq.pop_front()
   dq.push_back(1)
-  @assertion.assert_eq(dq[5], 1)?
+  @assertion.assert_eq(dq[4], 1)?
   dq.push_front(2)
   @assertion.assert_eq(dq[0], 2)?
 }
@@ -324,6 +354,12 @@ pub fn op_set[T](self : Deque[T], index : Int, value : T) -> Unit {
   }
 }
 
+test "op_set" {
+  let dq = Deque::[1,2,3,4,5]
+  dq[1] = 3
+  @assertion.assert_eq(dq[1], 3)?
+}
+
 /// Compares two deques for equality.
 pub fn op_equal[T : Eq](self : Deque[T], other : Deque[T]) -> Bool {
   if self.len != other.len {
@@ -337,6 +373,20 @@ pub fn op_equal[T : Eq](self : Deque[T], other : Deque[T]) -> Bool {
   true
 }
 
+test "op_equal" {
+  let dq1 = Deque::[1, 2, 3]
+  let dq2 = Deque::[1, 2, 3]
+  @assertion.assert_true(dq1 == dq2)?
+  let dq1 = Deque::[1, 2, 3]
+  let dq2 = Deque::[1, 2, 3]
+  dq2[0] = 2
+  @assertion.assert_false(dq1 == dq2)?
+  let dq1 = Deque::[1, 2, 3]
+  let dq2 = Deque::[1, 2, 3]
+  dq2.push_front(1)
+  @assertion.assert_false(dq1 == dq2)?
+}
+
 /// Iterates over the elements of the deque.
 /// 
 /// # Example