Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade polkadot-sdk to version 1.7.0 #2688

Closed
wants to merge 5 commits into from
Closed

Conversation

RomarQ
Copy link
Contributor

@RomarQ RomarQ commented Feb 29, 2024

What does it do?

This PR updates polkadot-sdk dependencies to version 1.7.2.

  • cherry-pick changes included in polkadot-v1.7.1 release
  • cherry-pick changes included in polkadot-v1.7.2 release

What important points reviewers should know?

Polkadot-sdk version 1.7.0 includes XCMv4, which removes the Multi prefix in many places, changes some XCM syntax (examples below) and removes Abstract variant from AssetId.

New syntax for building locations and junctions

Now junctions are built using the following methods:

let location = Location {
    parents: 1,
    interior: [Parachain(1000), PalletInstance(50), GeneralIndex(1984)].into()
};

or

let location = Location::new(1, [Parachain(1000), PalletInstance(50), GeneralIndex(1984)]);

And they are matched like so:

match location.unpack() {
  (1, [Parachain(id)]) => ...
  (0, Here) => ...,
  (1, [_]) => ...,
}

This syntax is mandatory in v4, and has been also implemented for v2 and v3 for easier migration.

This was needed to make all sizes smaller.

Removed Abstract asset id

Now assets are just constructed as follows:

let asset: Asset = (AssetId(Location::new(1, Here)), 100u128).into();
No need for specifying Concrete anymore.

Is there something left for follow-up PRs?

NO

Are there relevant PRs or issues in other repositories (Polkadot-sdk, Frontier)?

Runtime API

Identity pallet:

XCM:

XCM benchmarks

RewardDestination

RPC

Client

What value does it bring to the blockchain users?

@RomarQ RomarQ added the breaking Needs to be mentioned in breaking changes label Feb 29, 2024
@RomarQ RomarQ self-assigned this Feb 29, 2024
@RomarQ RomarQ added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Feb 29, 2024
@RomarQ
Copy link
Contributor Author

RomarQ commented Mar 6, 2024

Closed by #2700

@RomarQ RomarQ closed this Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant