Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Refund submission deposit #2091

Merged
merged 28 commits into from
Feb 14, 2023
Merged

Add Refund submission deposit #2091

merged 28 commits into from
Feb 14, 2023

Conversation

4meta5
Copy link
Contributor

@4meta5 4meta5 commented Feb 11, 2023

Adds refundSubmissionDeposit to referenda precompile (post dep update)

@4meta5 4meta5 added A0-pleasereview Pull request needs code review. B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit breaking Needs to be mentioned in breaking changes labels Feb 11, 2023
@4meta5 4meta5 changed the base branch from master to upgrade-v0.9.37 February 11, 2023 18:46
@4meta5
Copy link
Contributor Author

4meta5 commented Feb 11, 2023

I'll change base branch to master once #2072 is merged

Base automatically changed from upgrade-v0.9.37 to master February 13, 2023 14:54
nbaztec
nbaztec approved these changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@nbaztec nbaztec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but I think you need to run npm run pre-build-contracts to generate the new compiled JSON files.

@4meta5 4meta5 merged commit f6b6337 into master Feb 14, 2023
@4meta5 4meta5 deleted the amar-refund-submission-deposit branch February 14, 2023 18:14
@crystalin crystalin changed the title Refund submission deposit Add Refund submission deposit Feb 22, 2023
imstar15 pushed a commit to AvaProtocol/moonbeam that referenced this pull request May 16, 2023
@4meta5 @imstar15
Refund submission deposit (moonbeam-foundation#2091)
05ef17e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbaztec nbaztec nbaztec approved these changes

Assignees
No one assigned
Labels
A0-pleasereview Pull request needs code review. B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@4meta5 @nbaztec @crystalin