Embedded Questions: Update db query to fix the error thrown by 'Previous attempts' link #883644

Author: hieuvu

classes/output/renderer.php

@@ -73,9 +73,18 @@ public function embedded_question(\question_usage_by_activity $quba, int $slot,
             $output = $this->add_fill_with_correct_link($output);
         }
 
-        // We want to display the Previous attempts link only if there is atleast one completed attempt.
-        if (class_exists(report_embedquestion\attempt_summary_table::class) && $quba->question_count() > 1) {
-            $output = $this->add_embedded_question_report_link($quba, $slot, $output);
+        if (class_exists(report_embedquestion\attempt_summary_table::class)) {
+            // We want to display the Previous attempts link only if there is at least one completed attempt.
+            $hasattempts = false;
+            foreach ($quba->get_attempt_iterator() as $qa) {
+                if ($qa->get_state() !== \question_state::$todo) {
+                    $hasattempts = true;
+                    break;
+                }
+            }
+            if ($hasattempts) {
+                $output = $this->add_embedded_question_report_link($quba, $slot, $output);
+            }
         }
 
         return $output;

tests/attempt_test.php

@@ -317,8 +317,14 @@ public function test_question_rendering(): void {
             '</div>~';
         $this->assertMatchesRegularExpression($expectedregex, $html);
 
-        // Verify that the Previous attempts link is displayed for the second attempt.
+        /** @var \core_question_generator $questiongenerator */
+        $questiongenerator = $this->getDataGenerator()->get_plugin_generator('core_question');
         $attempt->start_new_attempt_at_question();
+        $postdata = $questiongenerator->get_simulated_post_data_for_questions_in_usage($attempt->get_question_usage(),
+            [1 => 'Sample answer'], true);
+        $attempt->process_submitted_actions($postdata);
+
+        // Verify that the Previous attempts link is displayed for the second attempt.
         $html = $attempt->render_question($renderer);
         $expectedregex = '~<div class="info"><h3 class="no">Question <span class="qno">[^<]+</span>' .
             '</h3><div class="state">Not complete</div><div class="grade">Marked out of 1.00</div>' .