Use decorator pattern to multi-thread update resolution

Author: wilkinsona

buildSrc/src/main/java/org/springframework/boot/build/bom/bomr/MultithreadedLibraryUpdateResolver.java

@@ -16,36 +16,40 @@
 
 package org.springframework.boot.build.bom.bomr;
 
-import java.time.Duration;
-import java.util.ArrayList;
 import java.util.Collection;
+import java.util.Collections;
 import java.util.List;
 import java.util.Map;
 import java.util.concurrent.ExecutionException;
 import java.util.concurrent.ExecutorService;
 import java.util.concurrent.Executors;
 import java.util.concurrent.Future;
+import java.util.stream.Collectors;
+import java.util.stream.Stream;
 
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
 import org.springframework.boot.build.bom.Library;
-import org.springframework.boot.build.bom.UpgradePolicy;
 
 /**
- * Uses multiple threads to find library updates.
+ * {@link LibraryUpdateResolver} decorator that uses multiple threads to find library
+ * updates.
  *
  * @author Moritz Halbritter
+ * @author Andy Wilkinson
  */
-class MultithreadedLibraryUpdateResolver extends StandardLibraryUpdateResolver {
+class MultithreadedLibraryUpdateResolver implements LibraryUpdateResolver {
 
 	private static final Logger LOGGER = LoggerFactory.getLogger(MultithreadedLibraryUpdateResolver.class);
 
 	private final int threads;
 
-	MultithreadedLibraryUpdateResolver(VersionResolver versionResolver, UpgradePolicy upgradePolicy, int threads) {
-		super(versionResolver, upgradePolicy);
+	private final LibraryUpdateResolver delegate;
+
+	MultithreadedLibraryUpdateResolver(int threads, LibraryUpdateResolver delegate) {
 		this.threads = threads;
+		this.delegate = delegate;
 	}
 
 	@Override
@@ -54,34 +58,28 @@ public List<LibraryWithVersionOptions> findLibraryUpdates(Collection<Library> li
 		LOGGER.info("Looking for updates using {} threads", this.threads);
 		ExecutorService executorService = Executors.newFixedThreadPool(this.threads);
 		try {
-			List<Future<LibraryWithVersionOptions>> jobs = new ArrayList<>();
-			for (Library library : librariesToUpgrade) {
-				if (isLibraryExcluded(library)) {
-					continue;
-				}
-				jobs.add(executorService.submit(() -> {
-					LOGGER.info("Looking for updates for {}", library.getName());
-					long start = System.nanoTime();
-					List<VersionOption> versionOptions = getVersionOptions(library, librariesByName);
-					LOGGER.info("Found {} updates for {}, took {}", versionOptions.size(), library.getName(),
-							Duration.ofNanos(System.nanoTime() - start));
-					return new LibraryWithVersionOptions(library, versionOptions);
-				}));
-			}
-			List<LibraryWithVersionOptions> result = new ArrayList<>();
-			for (Future<LibraryWithVersionOptions> job : jobs) {
-				try {
-					result.add(job.get());
-				}
-				catch (InterruptedException | ExecutionException ex) {
-					throw new RuntimeException(ex);
-				}
-			}
-			return result;
+			return librariesToUpgrade.stream()
+				.map((library) -> executorService.submit(
+						() -> this.delegate.findLibraryUpdates(Collections.singletonList(library), librariesByName)))
+				.flatMap(this::getResult)
+				.collect(Collectors.toList());
 		}
 		finally {
 			executorService.shutdownNow();
 		}
 	}
 
+	private Stream<LibraryWithVersionOptions> getResult(Future<List<LibraryWithVersionOptions>> job) {
+		try {
+			return job.get().stream();
+		}
+		catch (InterruptedException ex) {
+			Thread.currentThread().interrupt();
+			throw new RuntimeException(ex);
+		}
+		catch (ExecutionException ex) {
+			throw new RuntimeException(ex);
+		}
+	}
+
 }

buildSrc/src/main/java/org/springframework/boot/build/bom/bomr/UpgradeDependencies.java

@@ -209,8 +209,9 @@ private Issue findExistingUpgradeIssue(List<Issue> existingUpgradeIssues, Upgrad
 	@SuppressWarnings("deprecation")
 	private List<Upgrade> resolveUpgrades() {
 		List<Upgrade> upgrades = new InteractiveUpgradeResolver(getServices().get(UserInputHandler.class),
-				new MultithreadedLibraryUpdateResolver(new MavenMetadataVersionResolver(getRepositoryUris().get()),
-						this.bom.getUpgrade().getPolicy(), getThreads().get()))
+				new MultithreadedLibraryUpdateResolver(getThreads().get(),
+						new StandardLibraryUpdateResolver(new MavenMetadataVersionResolver(getRepositoryUris().get()),
+								this.bom.getUpgrade().getPolicy())))
 			.resolveUpgrades(matchingLibraries(getLibraries().getOrNull()), this.bom.getLibraries());
 		return upgrades;
 	}