Facebook Template Updates:

* removed more unused packages
* fixed an issue where using the default FacebookAuthorizeAttribute causes error
* made the facebook app URL configurable
* removed the unnecessary app.config

Author: yaohuang

src/Microsoft.AspNet.Mvc.Facebook/App.config

@@ -1,6 +1,8 @@
 // Copyright (c) Microsoft Open Technologies, Inc. All rights reserved. See License.txt in the project root for license information.
 
 using System;
+using System.Collections.Generic;
+using System.Globalization;
 using System.Linq;
 using System.Web;
 using System.Web.Mvc;
@@ -37,9 +39,9 @@ public void OnAuthorization(AuthorizationContext filterContext)
             // https://developers.facebook.com/docs/reference/dialogs/oauth/#parameters
 
             FacebookAuthorizationInfo authInfo;
-            if (!String.IsNullOrWhiteSpace(this.Permissions))
+            if (!String.IsNullOrWhiteSpace(Permissions))
             {
-                var permissions = this.Permissions.Split(',').Select((s) => s.Trim()).ToArray();
+                var permissions = Permissions.Split(',').Select(s => s.Trim()).ToArray();
                 authInfo = _facebookService.Authorize(filterContext.HttpContext, permissions);
             }
             else
@@ -64,13 +66,23 @@ public void OnAuthorization(AuthorizationContext filterContext)
                 {
                     appPath = FacebookSettings.AppId;
                 }
-                var redirectUri = "https://apps.facebook.com/" + appPath + filterContext.HttpContext.Request.Url.PathAndQuery;
-                var loginUrl = client.GetLoginUrl(new
+
+                var redirectUri = String.Format(CultureInfo.InvariantCulture,
+                    "{0}/{1}{2}",
+                    FacebookSettings.FacebookAppUrl.TrimEnd('/'),
+                    appPath,
+                    filterContext.HttpContext.Request.Url.PathAndQuery);
+
+                Dictionary<string, object> loginUrlParameters = new Dictionary<string, object>();
+                loginUrlParameters["redirect_uri"] = redirectUri;
+                loginUrlParameters["client_id"] = FacebookSettings.AppId;
+                if (!String.IsNullOrWhiteSpace(Permissions))
                 {
-                    scope = this.Permissions,
-                    redirect_uri = redirectUri,
-                    client_id = FacebookSettings.AppId
-                });
+                    loginUrlParameters["scope"] = Permissions;
+                }
+
+                var loginUrl = client.GetLoginUrl(loginUrlParameters);
+
                 var facebookAuthResult = new ContentResult();
                 facebookAuthResult.ContentType = "text/html";
                 facebookAuthResult.Content = String.Format("<script>window.top.location = '{0}';</script>", loginUrl.AbsoluteUri);

src/Microsoft.AspNet.Mvc.Facebook/Attributes/FacebookAuthorizeAttribute.cs

@@ -128,9 +128,6 @@
     </Compile>
   </ItemGroup>
   <ItemGroup>
-    <None Include="App.config">
-      <SubType>Designer</SubType>
-    </None>
     <None Include="packages.config">
       <SubType>Designer</SubType>
     </None>

src/Microsoft.AspNet.Mvc.Facebook/Microsoft.AspNet.Mvc.Facebook.csproj

@@ -6,6 +6,8 @@ namespace Microsoft.AspNet.Mvc.Facebook.Services
 {
     public static class FacebookSettings
     {
+        private static string _facebookAppUrl = "https://apps.facebook.com";
+
         static FacebookSettings()
         {
             DefaultUserStorageService = DefaultFacebookUserStorageService.Instance;
@@ -21,13 +23,25 @@ static FacebookSettings()
 
         public static IFacebookUserStorageService DefaultUserStorageService { get; set; }
         public static IFacebookObjectStorageService DefaultObjectStorageService { get; set; }
+        public static string FacebookAppUrl
+        {
+            get
+            {
+                return _facebookAppUrl;
+            }
+            set
+            {
+                _facebookAppUrl = value;
+            }
+        }
 
         public static void LoadFromConfig()
         {
             AppId = ConfigurationManager.AppSettings["Facebook.AppId"];
             AppSecret = ConfigurationManager.AppSettings["Facebook.AppSecret"];
             AppNamespace = ConfigurationManager.AppSettings["Facebook.AppNamespace"];
             RealtimeCallbackUrl = ConfigurationManager.AppSettings["Facebook.RealtimeCallbackUrl"];
+            FacebookAppUrl = ConfigurationManager.AppSettings["Facebook.FacebookAppUrl"] ?? _facebookAppUrl;
         }
     }
 }

src/Microsoft.AspNet.Mvc.Facebook/Services/FacebookSettings.cs

@@ -1,7 +1,5 @@
 <?xml version="1.0" encoding="utf-8"?>
 <packages>
-  <package id="AspNetMvc" version="4.0.20710.0" targetFramework="net40" />
-  <package id="AspNetWebApi" version="4.0.20710.0" targetFramework="net40" />
   <package id="EntityFramework" version="5.0.0" targetFramework="net40" />
   <package id="Facebook" version="6.0.24" targetFramework="net40" />
   <package id="Microsoft.AspNet.Mvc" version="4.0.20710.0" targetFramework="net40" />