Revert SKBitmap.Encode with SKPngEncoderOptions to previous behavior (2.88.8) #3014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
mattleibow
previously approved these changes
Oct 22, 2024
sungaila
force-pushed
the
revert-png-default-compression
branch
from
8d41a1f
to
987a360
Compare
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
mattleibow
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Reverts
SKBitmap.Encodeto previous behavior to use default PNG compression.Until 2.88.8: ZLibLevel 6 is used for PNG compression.
Since 3.0.0: ZLibLevel 0 is used for PNG compression.
Bugs Fixed
API Changes
None.
Behavioral Changes
Calling
SKBitmap.EncodeorSKPixmap.Encode (SKWStream, SKEncodedImageFormat, int)will result in a default PNG compression level (as in 2.88.8). TheSKPngEncoderFilterFlagsare unchanged.Required skia PR
None.
PR Checklist