CSharpSources: Dereference pointer variables #1753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a test for this? |
trungnt2910
force-pushed
the
dev/trungnt2910/pointervariable
branch
2 times, most recently
from
0b4d593 to
cb858bf
Compare
|
Done. I also made sure that the added test fails without the fix. |
Dereference pointers when generating getters for pointer variables. Otherwise, the managed instance would point to the pointer itself rather than the object at the native instance's address.
trungnt2910
force-pushed
the
dev/trungnt2910/pointervariable
branch
from
cb858bf to
199a73b
Compare
JordanL8
pushed a commit
to MoonCollider/CppSharp
that referenced
this pull request
Aug 29, 2023
Dereference pointers when generating getters for pointer variables. Otherwise, the managed instance would point to the pointer itself rather than the object at the native instance's address. (cherry picked from commit ce3d04a)
JordanL8
added a commit
to MoonCollider/CppSharp
that referenced
this pull request
Sep 7, 2023
* Incorrect build instructions on Windows (mono#1701) * Fix incorrect build instructions for Windows * Add link to Visual Studio installer * Refine building instructions for VS2019+ (cherry picked from commit c4a24b0) * Misc changes (mono#1710) * Minor code refactoring for re-use. * Add Class.FindVariable helper method. * Upgrade to .NET 6. (cherry picked from commit db7949b) * Add C++ WebAssembly ABI (mono#1711) * Minor code refactorings. * Fix debug assert issue with vtable methods. * Add support for WebAssembly C++ ABI to parser and AST converter. (cherry picked from commit 9b06e7b) * Add initial Emscripten generator. (mono#1712) (cherry picked from commit 117567d) * Code cleanups and improvements (mono#1713) * Code cleanups. * Run GetterSetterToPropertyPass for more generators. * Fixed compile warning when compiling parser bindings. * Cleanup driver code. * Remove dead 32-bit code. * Reduce verbosity when Options.Quiet is set. * Remove test compile-time warnings. * Move .NET tests to tests/dotnet. * Remove unused AST viewer code and premake-qt submodule. * Move tests2/ contents to tests/. (cherry picked from commit 4417dd9) * Publish package to nuget.org when a version tag is created (cherry picked from commit 5715df5) * Allow passing a `-target-framework` option to `build.sh` (mono#1718) Closes mono#1717. (cherry picked from commit 8cf6e3f) * Remove unused LLVM build flags. (cherry picked from commit 84b7276) * Update LLVM workflow to latest Action images. (cherry picked from commit 3d32fc7) * Update LLVM Windows workflow to latest Action images. (cherry picked from commit f9f9e9c) * Update action steps to latest to fix Node.js deprecation warnings. (cherry picked from commit 7d6decd) * Update LLVM build script for Visual Studio 2022. (cherry picked from commit b8a16a4) * Workaround Directory.Build.props getting picked up when building LLVM. This is to workaround MSBuild CMake step from LLVM build in Windows picking this up. (cherry picked from commit 25e2c7c) * Added variation of mono#1736 * Workaround parsing GNU system headers with GCC 11.0 version. (mono#1737) Closes mono#1703. Upstream bugs: llvm/llvm-project#51607 llvm/llvm-project#53152 (cherry picked from commit 0272532) * CppSharp.AST.Declaration - fix return QualifiedOriginalName, QualifiedLogicalOriginalName (mono#1740) Fixed properties getters of QualifiedOriginalName, QualifiedLogicalOriginalName and methods GetQualifiedName(), GatherNamespaces. (cherry picked from commit 9923d79) * CSharpExpressionPrinter: Wrap expression in parenthesis (mono#1741) Wrap default parameter expressions in parentheses to ensure whole expressions are casted instead of only the first operand. (cherry picked from commit 169f868) * Update README.md Remove Gitter since the link is 404 and we have not been using it anyway. (cherry picked from commit 160efb4) * CSharpExpressionPrinter: Recurse into operands (mono#1745) * CSharpExpressionPrinter: Recurse into operands Recursively call `VisitExpression` on the LHS and RHS of a binary operator expression. This fixes the generation for complex default parameters involving things other than two enumeration members. * CSharpSources: Use `const` when possible Generate `const` instead of `static` members when possible. This allows generated members to be used when compile-time constants are required, such as default parameters. (cherry picked from commit 1ce9cb7) * CSharp: More default parameter fixes (mono#1747) - Expression generation for `ConstructorReference` now also recursively calls `VisitExpression` for the argument if only one argument is detected. This allows correct overload generation for functions taking a variable as the default parameter value. - Default parameters of pointer-to-enumeration types are now correctly generated similar to primitive types. (cherry picked from commit add3aba) * Add type parameter to non-type template parameter decls. (mono#1749) (cherry picked from commit bb31bd6) * Update parser example to latest API. (cherry picked from commit 8c1fa18) * Fixed debugging printing when type printing delegate is not initialized. (cherry picked from commit 9f3ce76) * Array marshalling (mono#1748) * Generator: Customization for const char[] Allow the user to choose whether `const char[]` should be marshalled as `string` or a normal `char` array in C#. A new option `MarshalConstCharArrayAsString` is added, and is `true` by default. This helps in situations where the original C++ API distinguishes between C-strings and char arrays using the two different notations. * CSharpMarshal: Fix unknown length array marshal For unknown length arrays, also run a conversion loop if the primitive type encountered needs conversion (e.g. `char` to `sbyte`). * CSharpTypePrinter: Fix for boolean arrays (cherry picked from commit 357efec) * Add qualified template name to GetCXXRecordDeclFromBaseType. (mono#1751) (cherry picked from commit 626a362) * SymbolResolver: Use filename when path cannot be found (mono#1752) Uses bare filename to pass to `dlopen` when the full path cannot be detected. This helps on systems where library paths are not the same as $PATH. (cherry picked from commit 3978fb3) * CSharpSources: Dereference pointer variables (mono#1753) Dereference pointers when generating getters for pointer variables. Otherwise, the managed instance would point to the pointer itself rather than the object at the native instance's address. (cherry picked from commit ce3d04a) * Use TypePrinter.IntPtrType in CSharpSources.cs code from previous commit. (cherry picked from commit 3c31179) --------- Co-authored-by: aybe <aybe@users.noreply.github.com> Co-authored-by: João Matos <joao@tritao.eu> Co-authored-by: josetr <37419832+josetr@users.noreply.github.com> Co-authored-by: stachu99 <stachu99@users.noreply.github.com> Co-authored-by: Trung Nguyen <57174311+trungnt2910@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dereference pointers when generating getters for pointer variables. Otherwise, the managed instance would point to the pointer itself rather than the native instance's address.