Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated activesupport include catch 5.0 rails #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thealexauer
Copy link

I updated the gemspec, so it could work with Ruby on Rails 5.0, which requires ActiveSupport 5.0

The parsing works for me.

@gmodarelli
Copy link
Contributor

Hi @dompstar, thanks for the contribution.

I'm willing to merge the PR but the problem is that activesupport 5 requires Ruby version => 2.2.2

If you specify Ruby 2.2.2 in the xml2json.gemspec as the minimum Ruby version supported I'm ok with merging it and release the gem under a new tag. Please also specify this in the README.md.

One more thing. I realized that I had mistakenly committed and pushed the Gemfile.lock and it is causing Travis to fail the build. I removed it from master so if you remove it also from your fork we will have Travis passing also for this PR.

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants