Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation TODO for 3.x #29

Open
16 tasks
kanak opened this issue Mar 21, 2018 · 7 comments
Open
16 tasks

Documentation TODO for 3.x #29

kanak opened this issue Mar 21, 2018 · 7 comments

Comments

@kanak
Copy link
Contributor

kanak commented Mar 21, 2018

I hope this is OK, but I wanted to capture task ideas from @alexandru and @Avasil in #28 (comment) in a more visible place and also add a checklist.

  • Observable
  • Iterant (lots of documentation in Scaladocs)
  • Scheduler
    • clockRealtime / clockMonotonic
    • TracingScheduler
  • new Task features:
    • cancelable
    • uncancelable
    • onCancelRaiseError
    • bracket
    • start + cancel + Fiber
    • racePair
    • onErrorRestartLoop
  • TaskLocal
  • cats-effect integration
    • Timer
@Avasil
Copy link
Collaborator

Avasil commented Mar 21, 2018

Yeah I think it's a good idea to list everything, then do separate issues etc. It should be easier to cooperate on it. Ideally I'd see table of contents to fill. :D

Other stuff off the top of my head is cats-effect integration (related to Task and Iterant) with example (I was thinking about showing how to interoperate between Task and IO received from somewhere like http4s)

A lot of the changes can be noticed going through releases: https://monix.io/blog/2018/03/19/monix-v3.0.0-RC1.html

@alexandru
Copy link
Member

alexandru commented Mar 21, 2018

👍

FYI our competition for Iterant has a documentation microsite now, so checking that out is useful for inspiration 😊

https://functional-streams-for-scala.github.io/fs2/

This should also give us ideas about what's missing in Monix that's important — although those aren't a priority for the 3.0.0 release, because what's there already is pretty good and we can always add stuff afterwards.

Also the Task document needs a bigger section that talks of cancelation, like I wrote for cats.effect.IO: https://typelevel.org/cats-effect/datatypes/io.html#concurrency-and-cancelation

Just one piece of advice in case you start contributing — for documentation it's better to do it piecemeal, so prefer small PRs that can be merged faster.

Incomplete documentation is better than zero documentation 🙂

@alexandru alexandru changed the title Documentation Tasks for 3.x Documentation TODO for 3.x Mar 21, 2018
@alexandru
Copy link
Member

Btw guys, helping with the docs is extremely valuable, so thanks for taking initiative ❤️

@alexandru
Copy link
Member

FYI, I started to work on the Iterant document.

@Avasil
Copy link
Collaborator

Avasil commented Mar 22, 2018

Cool, I hope to have a bit more free time after a week or two and continue Observable

@kszlim
Copy link

kszlim commented Nov 22, 2019

startAndForget would be great to document too! Didn't realize monix had something like that until I really dug through the issues/code.

@Avasil
Copy link
Collaborator

Avasil commented Nov 22, 2019

@kszlim I have it on my todo list so I'll get to it eventually (though I focused on Observable more) unless you want to take a shot at it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants