Fix sync writing of hstore values (npgsql#5452)

NinoFloris · JonasWestman · commit 7c8f60ab239c · 2023-12-20T10:10:58.000+01:00
fixes npgsql#5445 (cherry picked from commit b21c41c) Signed-off-by: monjowe <jonas.westman@monitor.se>
diff --git a/src/Npgsql/Internal/Converters/HstoreConverter.cs b/src/Npgsql/Internal/Converters/HstoreConverter.cs
@@ -147,7 +147,7 @@ async ValueTask Write(bool async, PgWriter writer, T value, CancellationToken ca
                 if (async)
                     await writer.WriteCharsAsync(kv.Value.AsMemory(), _encoding, cancellationToken).ConfigureAwait(false);
                 else
-                    writer.WriteChars(kv.Key.AsSpan(), _encoding);
+                    writer.WriteChars(kv.Value.AsSpan(), _encoding);
             }
             i += 2;
         }

Original file line number	Diff line number	Diff line change
`@@ -147,7 +147,7 @@ async ValueTask Write(bool async, PgWriter writer, T value, CancellationToken ca`
`147`	`147`	`if (async)`
`148`	`148`	`await writer.WriteCharsAsync(kv.Value.AsMemory(), _encoding, cancellationToken).ConfigureAwait(false);`
`149`	`149`	`else`
`150`		`- writer.WriteChars(kv.Key.AsSpan(), _encoding);`
	`150`	`+ writer.WriteChars(kv.Value.AsSpan(), _encoding);`
`151`	`151`	`}`
`152`	`152`	`i += 2;`
`153`	`153`	`}`