Skip to content

REALMC-5056 - support queryParams for service delete and rule create, update, delete #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 24, 2020

Conversation

chickenbug
Copy link

This update adds query param support for:

  • service delete
  • rule create/update/delete

With this we can run those functions allow_destructive_changes when we want to ignore a destructive sync error.

As this update is not implementation specific, and since the idea of what is or is not destructive has not been finalized yet I opted not to add tests. Let me know if there's a better way to test or mock general param behavior!

Copy link
Contributor

@makesitgo makesitgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

straightforward enough... as far as tests go, do we have this implemented enough in the backend that you could write a test for each method here where it at least just utilizes and sends along the data specified in params here?

we don't need to be testing each and every failure case (leave that to the backend's suite of API and unit tests), but pick an obvious/simple one and just fire off the request so we know things behaved like we expected them to.

I do something similar here in test/admin/sync.test for the describe('data', ... test cases

🆒 beans

@chickenbug chickenbug merged commit 0c4e4b8 into mongodb:support/3.x Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants