REALMC-4874 - add sync progress to admin api

Author: chickenbug

.evg.yml

@@ -321,7 +321,7 @@ buildvariants:
     - rhel70
   expansions:
     go_url: "https://dl.google.com/go/go1.13.linux-amd64.tar.gz"
-    mongodb_url: https://fastdl.mongodb.org/linux/mongodb-linux-x86_64-4.0.2.tgz
+    mongodb_url: https://downloads.mongodb.com/linux/mongodb-linux-x86_64-enterprise-rhel70-4.4.0-rc3.tgz
     server_stitch_lib_url: 'https://s3.amazonaws.com/mciuploads/mongodb-mongo-master/stitch-support/enterprise-rhel-70-64-bit/18ca0d551818d6c8274358b8e6444640bec93c88/stitch-support-4.3.0-120-g18ca0d5.tgz'
     transpiler_target: node8-linux
     node_url: "https://nodejs.org/dist/v10.15.1/node-v10.15.1-linux-x64.tar.xz"

src/admin.js

@@ -497,7 +497,8 @@ export class StitchAdminClient extends StitchClient {
                 };
               },
               data: (params = {}) => api._get(`${syncUrl}/data`, params),
-              patchSchemas: data => api._patch(`${syncUrl}/schemas`, { body: JSON.stringify(data) })
+              patchSchemas: data => api._patch(`${syncUrl}/schemas`, { body: JSON.stringify(data) }),
+              progress: () => api._get(`${syncUrl}/progress`)
             };
           }
         };

test/admin/sync.test.js

@@ -225,38 +225,25 @@ describe('Sync', () => {
       expect(deployResult.status).toBe('created');
     });
 
-
-    it('can use the allow_destructive_changes param to do a destructive rule create', async() => {
+    it('can create a rule with invalid sync schema', async() => {
       const syncService = await createSampleMongodbSyncService(services);
 
       const schemaInvalidatingRule = {
         database: 'db',
         collection: 'coll',
         config: {
           schema: {
-            title: 'double',
             properties: {
               _id: { bsonType: 'objectId' },
               key: { bsonType: 'string' },
-              obj: {
-                bsonType: 'object',
-                title: 'double'
-              }
+              bad: { bsonType: 'null' }
             }
           }
         }
       };
 
-      let stitchError;
-      try {
-        await addRuleToMongodbService(services, syncService, schemaInvalidatingRule );
-      } catch (e) {
-        stitchError = e;
-      }
-      expect(stitchError.code).toBe('InvalidSyncSchema');
-
-      const createResult = await addRuleToMongodbService(services, syncService, schemaInvalidatingRule, { allow_destructive_changes: true });
-      expect(createResult).toBeTruthy();
+      const ruleResponse = await addRuleToMongodbService(services, syncService, schemaInvalidatingRule );
+      expect(ruleResponse._id).toBeTruthy();
     });
 
     it('can use the allow_destructive_changes param to do a destructive rule change', async() => {
@@ -332,4 +319,22 @@ describe('Sync', () => {
       expect(updateResult.status).toBe(204);
     });
   });
+
+  describe('progress', () => {
+    it('should 404 if there is no active sync service', async() => {
+      let errorCode;
+      try {
+        await sync.progress();
+      } catch (e) {
+        errorCode = e.response.status;
+      }
+      expect(errorCode).toBe(404);
+    });
+
+    it('should return a map of progress if there is an active sync service', async() => {
+      await createSampleMongodbSyncService(services);
+      const progressResponse = await sync.progress();
+      expect(progressResponse.progress).toEqual({});
+    });
+  });
 });