DRIVERS-2624 Improve prose tests checking that neither mongocryptd nor its client are created when they are not supposed to be
#1415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…are created when they are not supposed to be DRIVERS-2624
stIncMale
commented
May 5, 2023
| @@ -2490,7 +2506,7 @@ The following tests that a mongocryptd client is not created when shared library | |||
| .. code:: javascript | |||
|
|
|||
| { | |||
| "mongocryptdURI": "mongodb://localhost:27021" | |||
| "mongocryptdURI": "mongodb://localhost:27021/db?serverSelectionTimeoutMS=1000" | |||
There was a problem hiding this comment.
This change speeds up the test in a situation when the test fails. Tests in https://github.com/mongodb/specifications/tree/master/source/client-side-encryption/tests#bypass-spawning-mongocryptd already do this.
jmikola
reviewed
May 13, 2023
Co-authored-by: Jeremy Mikola <jmikola@gmail.com>
stIncMale
added a commit
to stIncMale/mongo-java-driver
that referenced
this pull request
May 16, 2023
jmikola
approved these changes
May 22, 2023
There was a problem hiding this comment.
In the interest of consistency, please add "DRIVERS-2624" to the PR title and ensure it's in the first line of the squashed merge commit.
I realize the issue is mentioned in the body of one of the commits, but the above is more useful when doing git-blame or searching the repo.
stIncMale
changed the title
mongocryptd nor its client are created when they are not supposed to bemongocryptd nor its client are created when they are not supposed to be
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRIVERS-2624
Please complete the following before merging: