fix: Invalid case on writeconcern makes skip check fail #2773
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When deprecating top-level writeConcern keys, some code was added to specifically skip them in
createUnifiedOptions
. You can see the change hereThis was ok for all keys except writeConcern, as the key being checked is cast to lowercase, but the original value is not. If given an input key of
writeConcern
it is converted towriteconcern
and then always compared againstwriteConcern
causing the check to always be false. This means that if you have connection options of:the createUnifiedOptions function will ultimately add w:1 to the final options object and result in deprecation errors being thrown, despite a valid config.
It seems the values in
skip
are not used anywhere else, so the simplest solution was to change the case of the value in theskip
array.