fix(url parser): make sure uri has 3 parts

mongodb · Nov 20, 2017 · aa9871b · aa9871b
1 parent fc09ca9
commit aa9871b
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/lib/url_parser.js b/lib/url_parser.js
@@ -17,6 +17,9 @@ module.exports = function(url, options, callback) {
   }
 
   if (result.protocol === 'mongodb+srv:') {
+    if (result.hostname.split('.').length < 3) {
+      return callback(new Error('uri does not have hostname, domainname and tld'))
+    }
     if (result.pathname && result.pathname.match(',')) {
       return callback(new Error('invalid uri, cannot contain multiple hostnames'));
     }

diff --git a/test/functional/url_parser_tests.js b/test/functional/url_parser_tests.js
@@ -1240,4 +1240,20 @@ describe('Url SRV Parser', function() {
       });
     }
   });
+
+  /**
+   * @ignore
+   */
+  it('should fail because host in URI does not have hostname, domainname and tld', {
+    metadata: {
+      requires: { topology: ['single'] }
+    },
+    test: function(done) {
+      parse('mongodb+srv://10gen.cc', function(err, object) {
+        expect(err).to.exist;
+        expect(err.message).to.equal('uri does not have hostname, domainname and tld');
+        done();
+      });
+    }
+  });
 });