feat: support creating collections and indexes in transactions

MongoDB 4.4 now supports creation of collections and indexes within
transactions. This patch includes that support as well as a spec
tests to validate the behavior.

NODE-2295

Author: mbroadst

test/functional/spec-runner/index.js

@@ -487,30 +487,57 @@ function resolveOperationArgs(operationName, operationArgs, context) {
 const CURSOR_COMMANDS = new Set(['find', 'aggregate', 'listIndexes', 'listCollections']);
 const ADMIN_COMMANDS = new Set(['listDatabases']);
 
+function maybeSession(operation, context) {
+  return (
+    operation &&
+    operation.arguments &&
+    operation.arguments.session &&
+    context[operation.arguments.session]
+  );
+}
+
 const kOperations = new Map([
   [
     'createIndex',
-    (operation, collection /*, context, options */) => {
+    (operation, collection, context /*, options */) => {
       const fieldOrSpec = operation.arguments.keys;
-      return collection.createIndex(fieldOrSpec);
+      const options = { session: maybeSession(operation, context) };
+      if (operation.arguments.name) options.name = operation.arguments.name;
+      return collection.createIndex(fieldOrSpec, options);
+    }
+  ],
+  [
+    'createCollection',
+    (operation, db, context /*, options */) => {
+      const collectionName = operation.arguments.collection;
+      const session = maybeSession(operation, context);
+      return db.createCollection(collectionName, { session });
+    }
+  ],
+  [
+    'dropCollection',
+    (operation, db, context /*, options */) => {
+      const collectionName = operation.arguments.collection;
+      const session = maybeSession(operation, context);
+      return db.dropCollection(collectionName, { session });
     }
   ],
   [
     'dropIndex',
     (operation, collection /*, context, options */) => {
       const indexName = operation.arguments.name;
-      return collection.dropIndex(indexName);
+      const session = maybeSession(operation, context);
+      return collection.dropIndex(indexName, { session });
     }
   ],
   [
     'mapReduce',
-    (operation, collection /*, context, options */) => {
+    (operation, collection, context /*, options */) => {
       const args = operation.arguments;
       const map = args.map;
       const reduce = args.reduce;
-      const options = {};
+      const options = { session: maybeSession(operation, context) };
       if (args.out) options.out = args.out;
-
       return collection.mapReduce(map, reduce, options);
     }
   ]

test/functional/transactions.test.js

@@ -9,8 +9,66 @@ const loadSpecTests = require('../spec').loadSpecTests;
 const generateTopologyTests = require('./spec-runner').generateTopologyTests;
 const MongoNetworkError = require('../../lib/core').MongoNetworkError;
 
+function ignoreNsNotFoundForListIndexes(err) {
+  if (err.code !== 26) {
+    throw err;
+  }
+
+  return [];
+}
+
+class TransactionsRunnerContext extends TestRunnerContext {
+  assertCollectionExists(options) {
+    const client = this.sharedClient;
+    const db = client.db(options.database);
+    const collectionName = options.collection;
+
+    return db
+      .listCollections()
+      .toArray()
+      .then(collections => expect(collections.some(coll => coll.name === collectionName)).to.be.ok);
+  }
+
+  assertCollectionNotExists(options) {
+    const client = this.sharedClient;
+    const db = client.db(options.database);
+    const collectionName = options.collection;
+
+    return db
+      .listCollections()
+      .toArray()
+      .then(
+        collections => expect(collections.every(coll => coll.name !== collectionName)).to.be.ok
+      );
+  }
+
+  assertIndexExists(options) {
+    const client = this.sharedClient;
+    const collection = client.db(options.database).collection(options.collection);
+    const indexName = options.index;
+
+    return collection
+      .listIndexes()
+      .toArray()
+      .catch(ignoreNsNotFoundForListIndexes)
+      .then(indexes => expect(indexes.some(idx => idx.name === indexName)).to.be.ok);
+  }
+
+  assertIndexNotExists(options) {
+    const client = this.sharedClient;
+    const collection = client.db(options.database).collection(options.collection);
+    const indexName = options.index;
+
+    return collection
+      .listIndexes()
+      .toArray()
+      .catch(ignoreNsNotFoundForListIndexes)
+      .then(indexes => expect(indexes.every(idx => idx.name !== indexName)).to.be.ok);
+  }
+}
+
 describe('Transactions', function() {
-  const testContext = new TestRunnerContext();
+  const testContext = new TransactionsRunnerContext();
 
   [
     { name: 'spec tests', specPath: 'transactions' },
@@ -36,7 +94,17 @@ describe('Transactions', function() {
           // This test needs there to be multiple mongoses
           'increment txnNumber',
           // Skipping this until SPEC-1320 is resolved
-          'remain pinned after non-transient error on commit'
+          'remain pinned after non-transient error on commit',
+
+          // Will be implemented as part of NODE-2034
+          'Client side error in command starting transaction',
+          'Client side error when transaction is in progress',
+
+          // Will be implemented as part of NODE-2538
+          'abortTransaction only retries once with RetryableWriteError from server',
+          'abortTransaction does not retry without RetryableWriteError label',
+          'commitTransaction does not retry error without RetryableWriteError label',
+          'commitTransaction retries once with RetryableWriteError from server'
         ];
 
         return SKIP_TESTS.indexOf(spec.description) === -1;
@@ -151,7 +219,7 @@ describe('Transactions', function() {
 
           const session = client.startSession();
           const db = client.db(configuration.db);
-          db.createCollection('transaction_error_test', (err, coll) => {
+          db.createCollection('transaction_error_test_2', (err, coll) => {
             expect(err).to.not.exist;
 
             session.startTransaction();