MONGOID-5162 - Remove BSON::ObjectId#as_json as we will defer to the bson-ruby gem implementation #5057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bson-ruby gem implementation.
|
Discussion BSON library behavior here: mongodb/bson-ruby#238 |
p-mongo
changed the title
p-mongo
approved these changes
Aug 26, 2021
comandeo
approved these changes
Aug 26, 2021
p-mongo
pushed a commit
to johnnyshields/mongoid
that referenced
this pull request
Sep 10, 2021
* upstream/master: (27 commits) Create security policy following github's template (mongodb#5070) MONGOID-5131 Use proper mdb <-> ubuntu versions (mongodb#5067) MONGOID-5131: Set up build pipeline for outside contributors (mongodb#5043) MONGOID-5165 Fix documentation link (mongodb#5065) Fix indentation MONGOID-5029 #empty method should use an #exists? rather than a #count query (mongodb#5029) MONGOID-5177 Fix flaky contextual spec (mongodb#5064) MONGOID-5170 - Fix more typos mostly in code docs and code comments (mongodb#5056) MONGOID-5105 Allow block form in Mongoid::Association::EmbedsMany::Proxy#count (mongodb#5060) MONGOID-5162 Add a release note for the planned changes in ObjectId#as_json (mongodb#5059) MONGOID-5171 - Make the minimum Ruby version 2.5 (mongodb#5058) MONGOID-5130 Remove conn count from client spec (mongodb#5055) Add driver 2.15 to compat table Fix MONGOID-5136 .touch with custom field is broken for embedded documents (mongodb#5039) MONGOID-5144 Add a deprecation warning when using the legacy query cache (mongodb#5042) MONGOID-???? Replace field[0] == ?$ with field.start_with?('$') -- easier to read and 30%+ faster (mongodb#5052) MONGOID-???? - Remove BSON::ObjectId#as_json as we will defer to the bson-ruby gem implementation. (mongodb#5057) MONGOID-4737 Deprecate the :compact option on Document#as_json (mongodb#5040) MONGOID-5143 [Code Comments Only] Remove magic comment "# encoding: utf-8" (mongodb#5041) Remove all @SInCE comments. These are generally not useful as: (mongodb#5037) ...
neilshweky
added a commit
to neilshweky/mongoid
that referenced
this pull request
Feb 9, 2022
… to the bson-ruby gem implementation. (mongodb#5057)" This reverts commit e8aae88.
neilshweky
added a commit
to neilshweky/mongoid
that referenced
this pull request
Feb 10, 2022
… to the bson-ruby gem implementation. (mongodb#5057)" This reverts commit e8aae88.
neilshweky
added a commit
to neilshweky/mongoid
that referenced
this pull request
Feb 14, 2022
… to the bson-ruby gem implementation. (mongodb#5057)" This reverts commit e8aae88.
neilshweky
added a commit
to neilshweky/mongoid
that referenced
this pull request
Feb 14, 2022
… to the bson-ruby gem implementation. (mongodb#5057)" This reverts commit e8aae88.
neilshweky
added a commit
to neilshweky/mongoid
that referenced
this pull request
Feb 15, 2022
… to the bson-ruby gem implementation. (mongodb#5057)" This reverts commit e8aae88.
neilshweky
added a commit
that referenced
this pull request
Feb 16, 2022
…#5141) * Revert "MONGOID-???? - Remove BSON::ObjectId#as_json as we will defer to the bson-ruby gem implementation. (#5057)" This reverts commit e8aae88. * MONGOID-5234 add feature flag for as_json * MONGOID-5234 add docs for new feature flag * MONGOID-5234 remove irrelevant tests and add docstring * MONGOID-5234 add default to configuration docs * MONGOID-5234 use dots instead of :: * MONGOID-5234 put test back * MONGOID-5234 update documentation and flip the flag * MONGOID-5234 fix up as_json comment * MONGOID-5234 update release notes * MONGOID-5234 change method signature
p-mongo
pushed a commit
that referenced
this pull request
Mar 11, 2022
…#5141) * Revert "MONGOID-???? - Remove BSON::ObjectId#as_json as we will defer to the bson-ruby gem implementation. (#5057)" This reverts commit e8aae88. * MONGOID-5234 add feature flag for as_json * MONGOID-5234 add docs for new feature flag * MONGOID-5234 remove irrelevant tests and add docstring * MONGOID-5234 add default to configuration docs * MONGOID-5234 use dots instead of :: * MONGOID-5234 put test back * MONGOID-5234 update documentation and flip the flag * MONGOID-5234 fix up as_json comment * MONGOID-5234 update release notes * MONGOID-5234 change method signature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.