Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mongodb/mongoid
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v9.0.0
Choose a base ref
...
head repository: mongodb/mongoid
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v9.0.1
Choose a head ref
  • 15 commits
  • 91 files changed
  • 10 contributors

Commits on May 10, 2024

  1. Mongoize is not called on update_all, when $set operator is used (#5814)

    * update tests to highlight a problem with mongoize in $set operation
    
    * fix params in mongoize_for method call and make $set operator to mongoize passed fields values
    
    * update method documentation
    
    * align with the mongoize_for method annotation
    
    * fix failing test
    dem authored May 10, 2024
    Configuration menu
    Copy the full SHA
    eec835a View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. Fix mongoize update all array operators master (#5823)

    * Change Mongoid::Criteria::Queryable::Selector#merge! to correctly merge $in and $nin when provided as a symbol as well as a string
    
    * Mongoid::Criteria::Queryable::Selector#merge! convert to strings before matching
    
    * cleanup whitespace
    
    * Cover all mongo array update operators with tests. Include $pull and $pop in special handling conditions for Mongoize
    
    * cleanup whitespace
    
    * prepare multiple entries in the data to be pulled from the array for $pullAll tests
    
    * fix spacing issue
    JohnMaguir authored May 20, 2024
    Configuration menu
    Copy the full SHA
    47c844c View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. DOCSP-38361 - Add text to empty pages (#5826)

    * add text to empty pages
    
    * fix
    mongoKart authored May 24, 2024
    Configuration menu
    Copy the full SHA
    69485bf View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2024

  1. 5508 touch on custom field (#5829)

    * [MONGOID-5508] Added a class for Label based on ticket example
    
    * [MONGOID-5508] Added a Band class based on issue example
    
    * [MONGOID-5508] Added class_name to Band,Label and included timestamps for managing updated_at
    
    * [MONGOID-5508] Added spec to test field is updated along with timestamps for parent and child
    
    * [MONGOID-5508] Added test for codepaths of save and destroy and fixed utc conversion. Off by 2 miliseconds
    
    * [MONGOID-5508] It passes tests with save, destroy, and touch codepaths too
    adviti-mishra authored Jun 11, 2024
    Configuration menu
    Copy the full SHA
    a5657dc View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2024

  1. Configuration menu
    Copy the full SHA
    1f1f1e7 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. MONGOID-5786: Fix some compatibility issues with Enumerable API (#5831)

    * Fix compatibility with Enumerable#sum API
    
    * Update documentation for the sum() method
    
    * Update documentation for sum() method
    
    ---------
    
    Co-authored-by: Jamis Buck <jamis.buck@mongodb.com>
    cperezabo and jamis authored Jun 17, 2024
    Configuration menu
    Copy the full SHA
    08547c3 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. Configuration menu
    Copy the full SHA
    d58d8e1 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. MONGOID-5743 SSDLC Requirements (#5834)

    * prep for SSDLC tasks (and remove old release flow)
    
    * address code-scanning concerns
    
    * permit code scanning on all branches
    
    * tie actions to a specific ref
    
    do we need to bump the v2 to v3 in order to get the ruby actions?
    
    * v2
    
    * use boolean type for dry-run flag
    jamis authored Jul 1, 2024
    Configuration menu
    Copy the full SHA
    b083e2c View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. MONGOID-5789 database_field_name given nil or empty string should rai…

    …se UnknownAttribute exception (#5836)
    
    * database_field_name given nil or empty string should raise UnknownAttribute exception
    
    * fix spec syntax
    
    * database_field_name return empty string instead of exception
    
    * `field` might be an empty string, not merely nil
    
    * fix specs to expect empty string instead of nil
    
    This is okay, because the database_field_name method is a private API.
    We can change the contract here without regard for who else might
    be using it.
    
    ---------
    
    Co-authored-by: Jamis Buck <jamis.buck@mongodb.com>
    danhealy and jamis authored Jul 12, 2024
    Configuration menu
    Copy the full SHA
    b2fec3e View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. Configuration menu
    Copy the full SHA
    971cf67 View commit details
    Browse the repository at this point in the history
  2. MONGOID-5790/MONGOID-5791 Fix error caused by loading a referenced cl…

    …ass prematurely (#5839)
    
    It's such a pleasure to delete dead code...and even more so when the
    dead-code is responsible for a bug, simply by existing!
    jamis authored Jul 15, 2024
    Configuration menu
    Copy the full SHA
    d2fcc26 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. Modified the comment to rightly indicate the error being raised is In…

    …validFind and not InvalidOptions (#5841)
    adviti-mishra authored Jul 18, 2024
    Configuration menu
    Copy the full SHA
    07761c8 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. 5688: Run callbacks for children within fibers (#5837)

    * Run callbacks for children within fibers
    
    * Comments for run child callbacks with around fibers
    
    * Removed the recursive implementation and renamed the fiber implementation to match the original function declaration
    
    * Message, summary, and resolution of invalid around callback implementation error
    
    * Class for invalid around callback error
    
    * try catch block to raise invalid around callbacks error when it is defined without a yield statement (it causes a terminated fiber to be resumed
    
    * Require the invalid around callback error
    
    * Refactored the rescuing of the exception to make it more elegant
    
    * invalid around callback error file is linter-approved
    
    * Fixed indentation for the rescue block
    
    * Spec for the case a user incorrectly defines an around callback without a yield
    
    * raising an invalid around callback error earlier on as soon as a fiber is detected to be dead
    
    * Changed the names of the classes for the invalid around callback spec
    
    * Modified the class names for the around callback without yield to avoid conflicts
    
    * Made the creation fo embedded documents in the around callbacks without yield spec more concise
    
    * Update spec/mongoid/interceptable_spec.rb to use logger
    
    Co-authored-by: Jamis Buck <jamisbuck@gmail.com>
    
    * removed the temporary field
    
    ---------
    
    Co-authored-by: Jamis Buck <jamisbuck@gmail.com>
    adviti-mishra and jamis authored Jul 19, 2024
    Configuration menu
    Copy the full SHA
    c5e092a View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2024

  1. Configuration menu
    Copy the full SHA
    a036165 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    15e2ba9 View commit details
    Browse the repository at this point in the history
Loading