MONGOID-4237 fix tests

Author: neilshweky

lib/mongoid/extensions/big_decimal.rb

@@ -54,7 +54,7 @@ def demongoize(object)
             if object.is_a?(BSON::Decimal128)
               demongoize_from_decimal128(object)
             elsif object.numeric?
-              ::BigDecimal.new(object.to_s)
+              BigDecimal(object.to_s) # TODO: this should be a ::BigDecimal
             end
           end
         end

spec/mongoid/criteria/queryable/extensions/big_decimal_spec.rb

@@ -11,7 +11,7 @@
       context "when provided a big decimal" do
 
         let(:big_decimal) do
-          BigDecimal.new("123456.789")
+          BigDecimal("123456.789")
         end
 
         it "returns the decimal as a string" do
@@ -29,11 +29,11 @@
       context "when provided an array of big decimals" do
 
         let(:bd_one) do
-          BigDecimal.new("123456.789")
+          BigDecimal("123456.789")
         end
 
         let(:bd_two) do
-          BigDecimal.new("123333.789")
+          BigDecimal("123333.789")
         end
 
         let(:array) do
@@ -74,7 +74,7 @@
       context "when provided a big decimal" do
 
         let(:big_decimal) do
-          BigDecimal.new("123456.789")
+          BigDecimal("123456.789")
         end
 
         it "returns the decimal as a BSON::Decimal128 object" do
@@ -92,11 +92,11 @@
       context "when provided an array of big decimals" do
 
         let(:bd_one) do
-          BigDecimal.new("123456.789")
+          BigDecimal("123456.789")
         end
 
         let(:bd_two) do
-          BigDecimal.new("123333.789")
+          BigDecimal("123333.789")
         end
 
         let(:array) do

spec/mongoid/extensions/big_decimal_spec.rb

@@ -30,7 +30,7 @@
         end
 
         it "returns a BigDecimal" do
-          expect(BigDecimal.demongoize(string)).to eq(BigDecimal.new(string))
+          expect(BigDecimal.demongoize(string)).to eq(BigDecimal(string))
         end
       end
 
@@ -41,7 +41,7 @@
         end
 
         it "returns a BigDecimal" do
-          expect(BigDecimal.demongoize(string)).to eq(BigDecimal.new(string))
+          expect(BigDecimal.demongoize(string)).to eq(BigDecimal(string))
         end
       end
 
@@ -52,7 +52,7 @@
         end
 
         it "returns a BigDecimal" do
-          expect(BigDecimal.demongoize(string)).to eq(BigDecimal.new(string))
+          expect(BigDecimal.demongoize(string)).to eq(BigDecimal(string))
         end
       end
 
@@ -205,7 +205,7 @@
       context "when the value is the BigDecimal zero" do
 
         let(:big_decimal) do
-          BigDecimal.new("0.0")
+          BigDecimal("0.0")
         end
 
         it "returns a string" do
@@ -216,7 +216,7 @@
       context "when the value is the BigDecimal negative zero" do
 
         let(:big_decimal) do
-          BigDecimal.new("-0.0")
+          BigDecimal("-0.0")
         end
 
         it "returns a string" do
@@ -347,7 +347,7 @@
       context "when the value is BigDecimal NaN" do
 
         let(:nan) do
-          BigDecimal.new("NaN")
+          BigDecimal("NaN")
         end
 
         it "returns a String" do
@@ -358,7 +358,7 @@
       context "when the value is BigDecimal Infinity" do
 
         let(:infinity) do
-          BigDecimal.new("Infinity")
+          BigDecimal("Infinity")
         end
 
         it "returns a String" do
@@ -369,7 +369,7 @@
       context "when the value is BigDecimal negative Infinity" do
 
         let(:neg_infinity) do
-          BigDecimal.new("-Infinity")
+          BigDecimal("-Infinity")
         end
 
         it "returns a String" do
@@ -456,7 +456,7 @@
         end
 
         it "returns a BigDecimal" do
-          expect(BigDecimal.demongoize(string)).to eq(BigDecimal.new(string))
+          expect(BigDecimal.demongoize(string)).to eq(BigDecimal(string))
         end
       end
 
@@ -467,7 +467,7 @@
         end
 
         it "returns a BigDecimal" do
-          expect(BigDecimal.demongoize(string)).to eq(BigDecimal.new(string))
+          expect(BigDecimal.demongoize(string)).to eq(BigDecimal(string))
         end
       end
 
@@ -478,7 +478,7 @@
         end
 
         it "returns a BigDecimal" do
-          expect(BigDecimal.demongoize(string)).to eq(BigDecimal.new(string))
+          expect(BigDecimal.demongoize(string)).to eq(BigDecimal(string))
         end
       end
 
@@ -625,7 +625,7 @@
       context "when the value is the BigDecimal zero" do
 
         let(:big_decimal) do
-          BigDecimal.new("0.0")
+          BigDecimal("0.0")
         end
 
         it "returns a BSON::Decimal128" do
@@ -636,7 +636,7 @@
       context "when the value is the BigDecimal negative zero" do
 
         let(:big_decimal) do
-          BigDecimal.new("-0.0")
+          BigDecimal("-0.0")
         end
 
         it "returns a BSON::Decimal128" do
@@ -775,7 +775,7 @@
       context "when the value is BigDecimal NaN" do
 
         let(:nan) do
-          BigDecimal.new("NaN")
+          BigDecimal("NaN")
         end
 
         it "returns a BSON::Decimal128 representation of BigDecimal NaN" do
@@ -786,7 +786,7 @@
       context "when the value is BigDecimal Infinity" do
 
         let(:infinity) do
-          BigDecimal.new("Infinity")
+          BigDecimal("Infinity")
         end
 
         it "returns a BSON::Decimal128 representation of BigDecimal Infinity" do
@@ -797,7 +797,7 @@
       context "when the value is BigDecimal negative Infinity" do
 
         let(:neg_infinity) do
-          BigDecimal.new("-Infinity")
+          BigDecimal("-Infinity")
         end
 
         it "returns a BSON::Decimal128 representation of BigDecimal negative Infinity" do

spec/mongoid/fields_spec.rb

@@ -1241,7 +1241,7 @@ class DiscriminatorChild2 < DiscriminatorParent
       end
 
       let(:decimal) do
-        BigDecimal.new("1000000.00")
+        BigDecimal("1000000.00")
       end
 
       context "when setting to a big decimal" do
@@ -1320,7 +1320,7 @@ class DiscriminatorChild2 < DiscriminatorParent
       end
 
       let(:decimal) do
-        BigDecimal.new("1000000.00")
+        BigDecimal("1000000.00")
       end
 
       context "when setting to a big decimal" do