RUST-1509 SDAM Logging #918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isabelatkinson
force-pushed
the
sdam-logging
branch
from
98a112e to
eede144
Compare
abr-egn
reviewed
Jul 25, 2023
| @@ -71,6 +71,12 @@ pub(crate) fn deserialize_spec_tests<T: DeserializeOwned>( | |||
| continue; | |||
| }; | |||
|
|
|||
| if let Ok(unskipped_filename) = std::env::var("TEST_FILE") { | |||
There was a problem hiding this comment.
Was this intentionally left in?
There was a problem hiding this comment.
I add this when I'm debugging pretty often to make it easier to run single tests, but I can delete if you'd rather not have it checked in
There was a problem hiding this comment.
Nah, it seems fine to leave in as long as it's deliberate :)
src/sdam/topology.rs
Outdated
| let tracing_emitter = | ||
| TopologyTracingEventEmitter::new(options.tracing_max_document_length_bytes, id); | ||
| let (tx, mut rx) = mpsc::unbounded_channel::<AcknowledgedMessage<SdamEvent>>(); | ||
| // Spin up a task to handle events so that a user's event handling code can't block |
There was a problem hiding this comment.
This isn't from your changes, but I don't think this comment is accurate - if the user's event handler blocks, that'll block whatever thread this task happens to be scheduled on, which could include the worker.
There was a problem hiding this comment.
good catch, I'll just remove this comment.
abr-egn
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.