RUST-1403 Remove oldtime feature from chrono dependency
#691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bajanam
changed the title
oldtime feature from chrono dependencyoldtime feature from chrono dependency
patrickfreed
approved these changes
Aug 29, 2022
|
On an unrelated note: there looks to be a bunch of failed tasks where all the tests passed. Should keep an eye on that and see if it comes up on more recent PRs (this is currently based off a pretty old branch). |
kmahar
approved these changes
Aug 29, 2022
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
oldtimefeature from chrono dependency to eliminate a transitive dependency on a deprecated version of the time crate which has a vulnerability.The issue was found using cargo-audit, which you might want to add to CI.