Skip to content

RUST-1857 Clean up names for multi-write errors #1102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 15, 2024
Merged

RUST-1857 Clean up names for multi-write errors #1102

merged 2 commits into from
May 15, 2024

Conversation

isabelatkinson
Copy link
Contributor

@isabelatkinson isabelatkinson commented May 14, 2024 •
edited
Loading

Main changes here:

  • ErrorKind::BulkWrite -> ErrorKind::InsertMany
  • BulkWriteFailure -> InsertManyError
  • BulkWriteError -> IndexedWriteError
  • ErrorKind::ClientBulkWrite -> ErrorKind::BulkWrite
  • ClientBulkWriteError -> BulkWriteError

The first three changes were on types only used for the insert_many API.

@isabelatkinson isabelatkinson requested a review from abr-egn May 14, 2024 19:54
@isabelatkinson isabelatkinson marked this pull request as ready for review May 14, 2024 20:05
@isabelatkinson isabelatkinson merged commit 6adb8c1 into mongodb:main May 15, 2024
@isabelatkinson isabelatkinson deleted the rename-bulk-errors branch May 17, 2024 14:14
@douggynix douggynix mentioned this pull request Jul 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abr-egn abr-egn abr-egn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isabelatkinson @abr-egn