RUST-1795 Remove unstable from in-use encryption (#1191)

Author: abr-egn

.evergreen/azure-kms-test/Cargo.toml

@@ -10,4 +10,4 @@ tokio = "1.28.1"
 
 [dependencies.mongodb]
 path = "../.."
-features = ["in-use-encryption-unstable", "azure-kms"]
+features = ["in-use-encryption", "azure-kms"]

.evergreen/config.yml

@@ -1607,7 +1607,7 @@ functions:
 
           echo "Building test ... begin"
           . ${PROJECT_DIRECTORY}/.evergreen/env.sh
-          cargo test get_exe_name --features in-use-encryption-unstable,gcp-kms -- --ignored
+          cargo test get_exe_name --features in-use-encryption,gcp-kms -- --ignored
           cp $(cat exe_name.txt) test-contents/test-exe
           echo "Building test ... end"
 

.evergreen/run-csfle-tests.sh

@@ -10,7 +10,7 @@ set -o xtrace
 
 export CSFLE_TLS_CERT_DIR="${DRIVERS_TOOLS}/.evergreen/x509gen"
 
-FEATURE_FLAGS+=("in-use-encryption-unstable" "aws-auth" "azure-kms")
+FEATURE_FLAGS+=("in-use-encryption" "aws-auth" "azure-kms")
 
 if [[ "$OPENSSL" = true ]]; then
   FEATURE_FLAGS+=("openssl-tls")

Cargo.toml

@@ -58,8 +58,9 @@ zlib-compression = ["dep:flate2"]
 snappy-compression = ["dep:snap"]
 
 # Enables support for client-side field level encryption and queryable encryption.
-# The In Use Encryption API is unstable and may have backwards-incompatible changes in minor version updates.
-in-use-encryption-unstable = ["dep:mongocrypt", "dep:rayon", "dep:num_cpus"]
+in-use-encryption = ["dep:mongocrypt", "dep:rayon", "dep:num_cpus"]
+# The in-use encryption API is stable; this is for backwards compatibility.
+in-use-encryption-unstable = ["in-use-encryption"]
 
 # Enables support for emitting tracing events.
 # The tracing API is unstable and may have backwards-incompatible changes in minor version updates.

README.md

@@ -44,7 +44,7 @@ features = ["sync"]
 | `zlib-compression`           | Enable support for compressing messages with [`zlib`](https://zlib.net/). |
 | `zstd-compression`           | Enable support for compressing messages with [`zstd`](http://facebook.github.io/zstd/). |
 | `snappy-compression`         | Enable support for compressing messages with [`snappy`](http://google.github.io/snappy/). |
-| `in-use-encryption-unstable` | Enable support for client-side field level encryption and queryable encryption. This API is unstable and may be subject to breaking changes in minor releases. |
+| `in-use-encryption`          | Enable support for client-side field level encryption and queryable encryption. |
 | `tracing-unstable`           | Enable support for emitting [`tracing`](https://docs.rs/tracing/latest/tracing/) events. This API is unstable and may be subject to breaking changes in minor releases. |
 | `compat-3-0-0`               | Required for future compatibility if default features are disabled. |
 

src/action.rs

@@ -6,7 +6,7 @@ mod client_options;
 mod count;
 mod create_collection;
 mod create_index;
-#[cfg(feature = "in-use-encryption-unstable")]
+#[cfg(feature = "in-use-encryption")]
 pub mod csfle;
 mod delete;
 mod distinct;

src/action/bulk_write.rs

@@ -120,7 +120,7 @@ where
     }
 
     async fn execute_inner(mut self) -> Result<R> {
-        #[cfg(feature = "in-use-encryption-unstable")]
+        #[cfg(feature = "in-use-encryption")]
         if self.client.should_auto_encrypt().await {
             use mongocrypt::error::{Error as EncryptionError, ErrorKind as EncryptionErrorKind};
 

src/action/create_collection.rs

@@ -64,7 +64,7 @@ impl<'a> CreateCollection<'a> {
         change_stream_pre_and_post_images: crate::db::options::ChangeStreamPreAndPostImages,
         clustered_index: crate::db::options::ClusteredIndex,
         comment: bson::Bson,
-        #[cfg(feature = "in-use-encryption-unstable")]
+        #[cfg(feature = "in-use-encryption")]
         encrypted_fields: Document,
     );
 

src/action/drop.rs

@@ -111,7 +111,7 @@ pub struct DropCollection<'a> {
 impl<'a> DropCollection<'a> {
     option_setters!(options: DropCollectionOptions;
         write_concern: WriteConcern,
-        #[cfg(feature = "in-use-encryption-unstable")]
+        #[cfg(feature = "in-use-encryption")]
         encrypted_fields: bson::Document,
     );
 

src/client.rs

@@ -1,6 +1,6 @@
 pub mod action;
 pub mod auth;
-#[cfg(feature = "in-use-encryption-unstable")]
+#[cfg(feature = "in-use-encryption")]
 pub(crate) mod csfle;
 mod executor;
 pub mod options;
@@ -11,7 +11,7 @@ use std::{
     time::{Duration, Instant},
 };
 
-#[cfg(feature = "in-use-encryption-unstable")]
+#[cfg(feature = "in-use-encryption")]
 pub use self::csfle::client_builder::*;
 use derivative::Derivative;
 use futures_core::Future;
@@ -123,7 +123,7 @@ struct ClientInner {
     options: ClientOptions,
     session_pool: ServerSessionPool,
     shutdown: Shutdown,
-    #[cfg(feature = "in-use-encryption-unstable")]
+    #[cfg(feature = "in-use-encryption")]
     csfle: tokio::sync::RwLock<Option<csfle::ClientState>>,
     #[cfg(test)]
     disable_command_events: AtomicBool,
@@ -159,7 +159,7 @@ impl Client {
                 pending_drops: SyncMutex::new(IdSet::new()),
                 executed: AtomicBool::new(false),
             },
-            #[cfg(feature = "in-use-encryption-unstable")]
+            #[cfg(feature = "in-use-encryption")]
             csfle: Default::default(),
             #[cfg(test)]
             disable_command_events: AtomicBool::new(false),
@@ -190,7 +190,7 @@ impl Client {
     /// # Ok(())
     /// # }
     /// ```
-    #[cfg(feature = "in-use-encryption-unstable")]
+    #[cfg(feature = "in-use-encryption")]
     pub fn encrypted_builder(
         client_options: ClientOptions,
         key_vault_namespace: crate::Namespace,
@@ -213,7 +213,7 @@ impl Client {
 
     /// Whether commands sent via this client should be auto-encrypted.
     pub(crate) async fn should_auto_encrypt(&self) -> bool {
-        #[cfg(feature = "in-use-encryption-unstable")]
+        #[cfg(feature = "in-use-encryption")]
         {
             let csfle = self.inner.csfle.read().await;
             match *csfle {
@@ -225,13 +225,13 @@ impl Client {
                 None => false,
             }
         }
-        #[cfg(not(feature = "in-use-encryption-unstable"))]
+        #[cfg(not(feature = "in-use-encryption"))]
         {
             false
         }
     }
 
-    #[cfg(all(test, feature = "in-use-encryption-unstable"))]
+    #[cfg(all(test, feature = "in-use-encryption"))]
     pub(crate) async fn mongocryptd_spawned(&self) -> bool {
         self.inner
             .csfle
@@ -241,7 +241,7 @@ impl Client {
             .map_or(false, |cs| cs.exec().mongocryptd_spawned())
     }
 
-    #[cfg(all(test, feature = "in-use-encryption-unstable"))]
+    #[cfg(all(test, feature = "in-use-encryption"))]
     pub(crate) async fn has_mongocryptd_client(&self) -> bool {
         self.inner
             .csfle
@@ -549,7 +549,7 @@ impl Client {
         &self.inner.topology
     }
 
-    #[cfg(feature = "in-use-encryption-unstable")]
+    #[cfg(feature = "in-use-encryption")]
     pub(crate) async fn primary_description(&self) -> Option<crate::sdam::ServerDescription> {
         let start_time = Instant::now();
         let timeout = self
@@ -578,7 +578,7 @@ impl Client {
         }
     }
 
-    #[cfg(feature = "in-use-encryption-unstable")]
+    #[cfg(feature = "in-use-encryption")]
     pub(crate) async fn auto_encryption_opts(
         &self,
     ) -> Option<tokio::sync::RwLockReadGuard<'_, csfle::options::AutoEncryptionOptions>> {