Add MongoClient and Database objects #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| public function selectDatabase($databaseName, WriteConcern $writeConcern = null, ReadPreference $readPreferences = null) | ||
| { | ||
| return new Database($this->manager, "{$databaseName}", $writeConcern, $readPreferences); |
There was a problem hiding this comment.
Isn't "{$databaseName}" redundant? I assume Database's constructor can do a string cast.
There was a problem hiding this comment.
Oh, its because I first did selectCollection() and then selectDatabase() copied from that :)
Fixed
bjori
force-pushed
the
mc-and-db-objects
branch
from
8c5b4db to
b42d45c
Compare
| use MongoDB\Database; | ||
| use MongoDB\Collection; | ||
|
|
||
| class MongoClient |
There was a problem hiding this comment.
We should consider switching this to Client, as "Mongo" is redundant here.
bjori
force-pushed
the
mc-and-db-objects
branch
from
b42d45c to
acefa85
Compare
bjori
force-pushed
the
mc-and-db-objects
branch
from
acefa85 to
94ff4de
Compare
bjori
added a commit
that referenced
this pull request
Mar 16, 2015
Add MongoClient and Database objects
Closed
GromNaN
pushed a commit
to GromNaN/mongo-php-library
that referenced
this pull request
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.