Skip to content

Commit 4b84bd9

Browse files
committed
PHPLIB-73: Database and Collection should inherit Manager's WC and RP
1 parent ced7145 commit 4b84bd9

File tree

1 file changed

+4
-8
lines changed

1 file changed

+4
-8
lines changed

src/Client.php

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@
1414
class Client
1515
{
1616
private $manager;
17-
private $readPreference;
18-
private $writeConcern;
1917

2018
/**
2119
* Constructs a new Client instance.
@@ -77,9 +75,8 @@ public function listDatabases(array $options = array())
7775
public function selectCollection($databaseName, $collectionName, WriteConcern $writeConcern = null, ReadPreference $readPreference = null)
7876
{
7977
$namespace = $databaseName . '.' . $collectionName;
80-
// TODO: inherit from Manager options once PHPC-196 is implemented
81-
$writeConcern = $writeConcern ?: $this->writeConcern;
82-
$readPreference = $readPreference ?: $this->readPreference;
78+
$writeConcern = $writeConcern ?: $this->manager->getWriteConcern();
79+
$readPreference = $readPreference ?: $this->manager->getReadPreference();
8380

8481
return new Collection($this->manager, $namespace, $writeConcern, $readPreference);
8582
}
@@ -97,9 +94,8 @@ public function selectCollection($databaseName, $collectionName, WriteConcern $w
9794
*/
9895
public function selectDatabase($databaseName, WriteConcern $writeConcern = null, ReadPreference $readPreference = null)
9996
{
100-
// TODO: inherit from Manager options once PHPC-196 is implemented
101-
$writeConcern = $writeConcern ?: $this->writeConcern;
102-
$readPreference = $readPreference ?: $this->readPreference;
97+
$writeConcern = $writeConcern ?: $this->manager->getWriteConcern();
98+
$readPreference = $readPreference ?: $this->manager->getReadPreference();
10399

104100
return new Database($this->manager, $databaseName, $writeConcern, $readPreference);
105101
}

0 commit comments

Comments
 (0)