This repository was archived by the owner on Feb 28, 2025. It is now read-only.
Fix accepted stage type in FluentFactoryTrait #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
force-pushed
the
fluent-stages-type
branch
from
bae09dd to
bc2fd96
Compare
3 tasks
jmikola
reviewed
Mar 25, 2024
|
|
||
| $trait->addProperty('pipeline') | ||
| ->setType('array') | ||
| ->setComment('@var list<StageInterface>') | ||
| ->setComment('@var list<StageInterface|array<string,mixed>|stdClass>') |
There was a problem hiding this comment.
Why was stdClass added? In https://github.com/mongodb/laravel-mongodb/pull/2738/files#r1536149792, you only needed array<string,mixed>.
There was a problem hiding this comment.
Because that's what is accepted by the Pipeline class.
There was a problem hiding this comment.
An existing Pipeline object is also accepted by the Pipeline constructor (for appending IIRC). I just assumed this would be as restrictive as possible based on what the trait enables users to do.
Defer to you.
There was a problem hiding this comment.
The property is public. The user can append anything to the array.
jmikola
approved these changes
Mar 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix mongodb/laravel-mongodb#2738 (comment)
Get the stage type accepted by
Pipeline.mongo-php-builder/src/Builder/Pipeline.php
Line 23 in aa4f34c