Sync unified change-streams tests #1550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhachicha
reviewed
Oct 31, 2024
| @@ -48,6 +48,12 @@ final class ChangeStreamsTest extends UnifiedReactiveStreamsTest { | |||
| "Test that comment is not set on getMore - pre 4.4" | |||
| ); | |||
|
|
|||
| private static final List<String> TESTS_WITH_EXTRA_EVENTS = | |||
| Arrays.asList( | |||
| "Test with document comment", | |||
There was a problem hiding this comment.
There's also Test with document comment - pre 4.4 should this one also be skipped as well?
Never mind this is already skipped by https://github.com/mongodb/mongo-java-driver/pull/1550/files#diff-d13241ef919ff6af0a634af668614719b4827edb20476a9144c7814e78b5d7fbR42
There was a problem hiding this comment.
It is skipped via ERROR_REQUIRED_FROM_CHANGE_STREAM_INITIALIZATION_TESTS above.
nhachicha
approved these changes
Oct 31, 2024
|
sorry, I closed this PR by accident. I intended to close another one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.