Allow valid SRV hostnames with less than 3 parts #1525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanQingyangXu
force-pushed
the
JAVA-5542
branch
from
63c5ffe
to
86b3b81
Compare
NathanQingyangXu
requested review from
a team and
rozza
and removed request for
a team
NathanQingyangXu
force-pushed
the
JAVA-5542
branch
3 times, most recently
from
c3d2782
to
36811a2
Compare
NathanQingyangXu
force-pushed
the
JAVA-5542
branch
from
36811a2
to
49ee4c4
Compare
jyemin
requested review from
vbabanin and
katcharov
and removed request for
vbabanin
katcharov
requested changes
Oct 18, 2024
driver-core/src/main/com/mongodb/internal/dns/DefaultDnsResolver.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/dns/DefaultDnsResolver.java
Outdated
Show resolved
Hide resolved
...core/src/test/unit/com/mongodb/internal/connection/InitialDnsSeedListDiscoveryProseTest.java
Outdated
Show resolved
Hide resolved
...core/src/test/unit/com/mongodb/internal/connection/InitialDnsSeedListDiscoveryProseTest.java
Outdated
Show resolved
Hide resolved
...core/src/test/unit/com/mongodb/internal/connection/InitialDnsSeedListDiscoveryProseTest.java
Show resolved
Hide resolved
…redundant code comment as per code review comment
…at 'resolvedHost' might not contain '.'
NathanQingyangXu
force-pushed
the
JAVA-5542
branch
from
9535d5d
to
fb9feb5
Compare
katcharov
approved these changes
Oct 24, 2024
| @@ -64,13 +64,19 @@ public DefaultDnsResolver(@Nullable final DnsClient dnsClient) { | |||
|
|
|||
| The priority and weight are ignored, and we just concatenate the host (after removing the ending '.') and port with a | |||
| ':' in between, as expected by ServerAddress. | |||
|
|
|||
| It's required that the srvHost has at least three parts (e.g. foo.bar.baz) and that all of the resolved hosts have a parent | |||
| domain equal to the domain of the srvHost. | |||
There was a problem hiding this comment.
Optional since this is internal, but consider replacing this with the revised conditions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/JAVA-5542