Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate com.mongodb.client.unified.UnifiedTest and all its descendants to JUnit 5 #1410

Merged
merged 2 commits into from
Jul 12, 2024

Conversation

stIncMale
Copy link
Member

@stIncMale stIncMale commented Jun 6, 2024

  • Had to move most of UnifiedTest.setUp to UnifiedTest.shouldPassAllOutcomes because there is no out of the box way to inject test parameters in UnifiedTest.setUp, and JUnit Pioneer also does not have such an extension. This is, however, technically possible based on JUnit 5 docs, and https://stackoverflow.com/a/69265907 suggests a solution.
    • Started implementing a solution based on https://stackoverflow.com/a/69265907, then discovered that we already have it implemented as AfterBeforeParameterResolver, so just reused.

I also added some more new and potentially useful info to JAVA-5393: Retry non-buggy flaky tests.

JAVA-5495

@stIncMale stIncMale self-assigned this Jun 6, 2024
@stIncMale stIncMale force-pushed the JAVA-5495 branch 7 times, most recently from c76a97b to dd860a3 Compare July 11, 2024 20:52
@stIncMale stIncMale marked this pull request as ready for review July 11, 2024 20:54
@stIncMale stIncMale requested review from a team and rozza and removed request for a team July 11, 2024 20:55
Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Firstly - changes look good.

However, there appears to be a discrepency in the number of tests against master:

I'm going to update with master just to double check them.

@rozza
Copy link
Member

rozza commented Jul 12, 2024

Thats all it was - merged in master and counts for those two are equal 👍

Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stIncMale stIncMale merged commit 722d983 into mongodb:master Jul 12, 2024
59 checks passed
@stIncMale stIncMale deleted the JAVA-5495 branch July 12, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants