-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate com.mongodb.client.unified.UnifiedTest
and all its descendants to JUnit 5
#1410
Conversation
c76a97b
to
dd860a3
Compare
…nts/users to JUnit 5 JAVA-5495
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Firstly - changes look good.
However, there appears to be a discrepency in the number of tests against master:
-
Master: 4.0 Replica Set NoAuth NoSSL JDK8 Linux 15698/15698 tests
-
Patch: 4.0 Replica Set NoAuth NoSSL JDK8 Linux: 15666/15666 tests
-
Master: latest Sharded Cluster Auth SSL JDK8 Linux 15725/15725 tests
-
Patch: latest Sharded Cluster Auth SSL JDK8 Linux 15693/15693 tests
I'm going to update with master just to double check them.
Thats all it was - merged in master and counts for those two are equal 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Had to move most ofUnifiedTest.setUp
toUnifiedTest.shouldPassAllOutcomes
because there is no out of the box way to inject test parameters inUnifiedTest.setUp
, and JUnit Pioneer also does not have such an extension. This is, however, technically possible based on JUnit 5 docs, and https://stackoverflow.com/a/69265907 suggests a solution.AfterBeforeParameterResolver
, so just reused.I also added some more new and potentially useful info to JAVA-5393: Retry non-buggy flaky tests.
JAVA-5495