Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy shell from test scripts #1404

Merged
merged 2 commits into from
May 30, 2024
Merged

Conversation

jyemin
Copy link
Contributor

@jyemin jyemin commented May 29, 2024

The legacy shell was only used in AWS authentication tests, so updating those gets rid of the last remaining use of the legacy shell.

JAVA-4791

@jyemin jyemin self-assigned this May 29, 2024
@jyemin jyemin marked this pull request as draft May 29, 2024 17:46
The legacy shell was only used in AWS authentication tests, so updating
those gets rid of the last remaining use of the legacy shell.

JAVA-4791
This is how it was before, just missed it.
@jyemin jyemin marked this pull request as ready for review May 30, 2024 02:53
@jyemin
Copy link
Contributor Author

jyemin commented May 30, 2024

Finally took the blinders off and spotted it. We had previously been skipping web identity test using the built-in AWS credential provider, but when I copied the Evergreen configuration from the Go driver example I inadvertently removed the skipping logic. Added it back in second commit and tests are "passing" again.

@jyemin jyemin merged commit 46fda2f into mongodb:master May 30, 2024
57 of 62 checks passed
@jyemin jyemin deleted the JAVA-4791 branch May 30, 2024 16:48
jyemin added a commit that referenced this pull request Jun 7, 2024
The legacy shell was only used in AWS authentication tests, so updating
those gets rid of the last remaining use of the legacy shell.

JAVA-4791
vbabanin pushed a commit to vbabanin/mongo-java-driver that referenced this pull request Sep 5, 2024
The legacy shell was only used in AWS authentication tests, so updating
those gets rid of the last remaining use of the legacy shell.

JAVA-4791
vbabanin pushed a commit to vbabanin/mongo-java-driver that referenced this pull request Nov 5, 2024
The legacy shell was only used in AWS authentication tests, so updating
those gets rid of the last remaining use of the legacy shell.

JAVA-4791

(cherry picked from commit 46fda2f)
vbabanin added a commit that referenced this pull request Nov 6, 2024
The legacy shell was only used in AWS authentication tests, so updating
those gets rid of the last remaining use of the legacy shell.

JAVA-4791

(cherry picked from commit 46fda2f)
Co-authored-by: Jeff Yemin <jeff.yemin@mongodb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant