Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Spotbugs 6.0.15 #1398

Merged
merged 4 commits into from
May 27, 2024
Merged

Upgrade to Spotbugs 6.0.15 #1398

merged 4 commits into from
May 27, 2024

Conversation

jyemin
Copy link
Contributor

@jyemin jyemin commented May 22, 2024

  • Exclude CT_CONSTRUCTOR_THROW
  • Exclude PA_PUBLIC_PRIMITIVE_ATTRIBUTE
  • Add assertion to handle NP warning

JAVA-5480

* Exclude CT_CONSTRUCTOR_THROW
* Exclude PA_PUBLIC_PRIMITIVE_ATTRIBUTE
* Add assertion to handle NP warning

JAVA-5480
@jyemin jyemin requested a review from stIncMale May 22, 2024 14:28
@jyemin jyemin self-assigned this May 22, 2024
@@ -18,6 +18,17 @@
for the mapping from SpotBugs rank to verbal labels.
-->
<FindBugsFilter>
<Match>
<!-- MongoDB status: "No Fix Needed", SpotBugs rank: * -->
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stIncMale how did you determine the ranks? Above comment says to look at https://spotbugs.readthedocs.io/en/latest/filter.html#rank but I don't see anything useful at that location.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I determined the ranks as described in #1392:

To get the rank data, I had enabled SpotBugs XML reports, then was commenting out parts of exclude.xml and manually get the rank data from the XML reports.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Above comment says to look at https://spotbugs.readthedocs.io/en/latest/filter.html#rank but I don't see anything useful at that location.

It says to look at the page "for the mapping from SpotBugs rank to verbal labels", and the mapping is there. This is in case we decide to map the numbers to something more human-friendly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, got it. I added the ranks and a comment saying how to find them, for our future selves.

@jyemin jyemin merged commit a34cb31 into mongodb:master May 27, 2024
59 checks passed
@jyemin jyemin deleted the JAVA-5480 branch May 27, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants