Skip to content

JAVA-5311 #1305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

JAVA-5311 #1305

wants to merge 3 commits into from

Conversation

jyemin
Copy link
Collaborator

@jyemin jyemin commented Feb 2, 2024

No description provided.

@jyemin jyemin requested review from dylrich and rozza February 2, 2024 22:49
Copy link
Contributor

@dylrich dylrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately its still leaks in the logs.

Search the logs for gcpEmail and you can see the property in plain text in the logs. Look for "Starting process 'Gradle Test Executor"

What I don't understand is that some are marked as redacted. eg: REDACTED:variable_name. I can't determine where / how that is done - perhaps by evergreen.

Choices seem to be:

  • ensure all variables are redacted via the same mechanism.
  • Turn of info logging for gradle.

@jyemin
Copy link
Collaborator Author

jyemin commented Feb 6, 2024

Ensure all variables are redacted via the same mechanism.

You're right that Evergreen is doing this for us. The point of this PR is not to rely on that redaction.

Turn of info logging for gradle.

Not ideal as it's often needed for debugging

How about instead we use environment variables, as those shouldn't be logged (see publish.sh for the signing keys)

@jyemin jyemin requested a review from dylrich February 6, 2024 11:44
@rozza
Copy link
Member

rozza commented Feb 6, 2024

Using env's sounds like a plan

@jyemin
Copy link
Collaborator Author

jyemin commented Feb 21, 2024

Superseded by #1314.

@jyemin jyemin closed this Feb 21, 2024
@jyemin jyemin deleted the j5311 branch March 14, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants