Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull mongohouse image from ADL ECR repo #1274

Merged
merged 5 commits into from
Dec 7, 2023
Merged

Pull mongohouse image from ADL ECR repo #1274

merged 5 commits into from
Dec 7, 2023

Conversation

jyemin
Copy link
Contributor

@jyemin jyemin commented Dec 7, 2023

@jyemin jyemin self-assigned this Dec 7, 2023
@jyemin jyemin requested a review from rozza December 7, 2023 15:07
@jyemin
Copy link
Contributor Author

jyemin commented Dec 7, 2023

Just realized it would probably be better to split this into two PRs. WDYT?

rozza
rozza approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - although whats happened to the patch build?

@jyemin
Copy link
Contributor Author

jyemin commented Dec 7, 2023

LGTM - although whats happened to the patch build?

I just killed all the variants except the one I changed.

@jyemin jyemin merged commit 9286233 into mongodb:master Dec 7, 2023
1 of 10 checks passed
@jyemin jyemin deleted the j5235 branch December 7, 2023 16:48
vbabanin added a commit to vbabanin/mongo-java-driver that referenced this pull request Sep 5, 2024
@vbabanin
Pull mongohouse image from ADL ECR repo (mongodb#1274)
4c81a75 
JAVA-5235
vbabanin pushed a commit to vbabanin/mongo-java-driver that referenced this pull request Nov 5, 2024
@jyemin @vbabanin
Pull mongohouse image from ADL ECR repo (mongodb#1274)
c57e254 
Updated ADL test batch size assertion to match Java driver behavioral change introduced in JAVA-5159

JAVA-5235

(cherry picked from commit 9286233)
@vbabanin vbabanin mentioned this pull request Nov 5, 2024
Merged
vbabanin added a commit that referenced this pull request Nov 6, 2024
@vbabanin
Pull mongohouse image from ADL ECR repo (#1274) (#1561)
ce5a55b 
Updated ADL test batch size assertion to match Java driver behavioral change introduced in JAVA-5159

JAVA-5235

(cherry picked from commit 9286233)
Co-authored-by: Jeff Yemin <jeff.yemin@mongodb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rozza rozza rozza approved these changes

Assignees

@jyemin jyemin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jyemin @rozza