Skip to content

Implement prose tests checking that neither mongocryptd nor its client are created when they are not supposed to be #1113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stIncMale merged 6 commits into from
May 19, 2023
Merged

Implement prose tests checking that neither mongocryptd nor its client are created when they are not supposed to be #1113

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f77fbc8
Add test #20
stIncMale Apr 27, 2023
7925496
Add tests #8
stIncMale May 2, 2023
2e1a236
Remove `NoCheckedAutoCloseable` and use `@SuppressWarnings("try")` on…
stIncMale May 5, 2023
0a70bc6
Add the requested comment
stIncMale May 11, 2023
6241f65
Implement improvements from
stIncMale May 16, 2023
5008efc
Update test patterns in `run-csfle-tests-with-mongocryptd.sh`
stIncMale May 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions .evergreen/run-csfle-tests-with-mongocryptd.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,10 @@ echo "Running tests with Java ${JAVA_VERSION}"
${GRADLE_EXTRA_VARS} \
--stacktrace --info --continue \
driver-legacy:test \
--tests com.mongodb.ClientSideEncryptionLegacyTest \
--tests "*.ClientEncryption*" --tests "*.ClientSideEncryption*" \
driver-sync:test \
--tests com.mongodb.client.ClientSideEncryptionTest \
--tests com.mongodb.client.unified.ClientSideEncryptionTest \
--tests "*.ClientEncryption*" --tests "*.ClientSideEncryption*" \
driver-reactive-streams:test \
--tests com.mongodb.reactivestreams.client.ClientSideEncryptionTest \
--tests com.mongodb.reactivestreams.client.unified.ClientSideEncryptionTest \
--tests "*.ClientEncryption*" --tests "*.ClientSideEncryption*" \
driver-scala:integrationTest \
--tests org.mongodb.scala.ClientSideEncryptionTest
--tests "*.ClientEncryption*" --tests "*.ClientSideEncryption*"
Copy link
Member Author

@stIncMale stIncMale May 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change together with the assumeFalse/assumeTrue(CRYPT_SHARED_LIB_PATH_SYS_PROP_VALUE != null) checks in AbstractClientSideEncryptionNotSpawnMongocryptdTest solves the issue discussed in https://mongodb.slack.com/archives/CFPHLTRMK/p1683160528003019: some of the tests added in this PR not only do not require crypt_shared, but require the library not to be loaded, which is why they are run separately (in different process) from those that load crypt_shared (once it is loaded, it can't be unloaded).

Copy link
Collaborator

@jyemin jyemin May 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad this worked out so easily.

Loading