Do not perform server selection to determine sessions support #1092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead, check for session support during operation execution after the connection is checked out. JAVA-4860
jyemin
commented
Mar 2, 2023
| } | ||
| if (sessionContext.hasSession() && responseExpected) { | ||
| extraElements.add(new BsonElement("lsid", sessionContext.getSessionId())); | ||
| if (sessionContext.hasSession()) { |
Collaborator
Author
There was a problem hiding this comment.
This is really the crux of the whole change. A few notes:
- All application-initiated messages now have a session, so the only time this is false is for SDAM-related connection
- This seems a bit late to be checking for unsupported explicit sessions, but it's the only place to put it that wouldn't result in code duplication, since sync and async paths all end up here
- In practice, almost every server that the driver could actually connect to (3.6+) supports sessions, so the only time
isSessionSupportedwill return false is a 3.6 server in 3.4 FCV mode, or a mongocryptd server.
driver-core/src/main/com/mongodb/internal/operation/OperationHelper.java
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/operation/OperationHelper.java
Show resolved
Hide resolved
driver-sync/src/test/functional/com/mongodb/client/AbstractSessionsProseTest.java
Show resolved
Hide resolved
driver-sync/src/test/functional/com/mongodb/client/AbstractSessionsProseTest.java
Show resolved
Hide resolved
rozza
approved these changes
Mar 3, 2023
katcharov
requested changes
Mar 3, 2023
driver-sync/src/test/functional/com/mongodb/client/AbstractSessionsProseTest.java
Show resolved
Hide resolved
driver-sync/src/test/functional/com/mongodb/client/AbstractSessionsProseTest.java
Show resolved
Hide resolved
driver-sync/src/test/functional/com/mongodb/client/AbstractSessionsProseTest.java
Show resolved
Hide resolved
driver-sync/src/test/functional/com/mongodb/client/AbstractSessionsProseTest.java
Show resolved
Hide resolved
driver-sync/src/test/functional/com/mongodb/client/AbstractSessionsProseTest.java
Show resolved
Hide resolved
driver-sync/src/test/functional/com/mongodb/client/AbstractSessionsProseTest.java
Show resolved
Hide resolved
driver-sync/src/test/functional/com/mongodb/client/AbstractSessionsProseTest.java
Show resolved
Hide resolved
katcharov
approved these changes
Mar 8, 2023
driver-sync/src/test/functional/com/mongodb/client/AbstractSessionsProseTest.java
Show resolved
Hide resolved
jyemin
commented
Mar 8, 2023
...active-streams/src/main/com/mongodb/reactivestreams/client/internal/ClientSessionHelper.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, check for session support during operation execution after the connection is checked out.
JAVA-4860