-
Notifications
You must be signed in to change notification settings - Fork 918
Retry Markdown link checks on HTTP 429. #2181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🧪 Performance ResultsCommit SHA: 58e700aThe following benchmark tests for version 68b1d98d76cdc90007376ad7 had statistically significant changes (i.e., |z-score| > 1.96):
For a comprehensive view of all microbenchmark results for this PR's commit, please check out the Evergreen perf task for this patch. |
API Change ReportNo changes found! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds retry functionality to the markdown link checker to handle HTTP 429 "Too Many Requests" responses, specifically addressing frequent failures from http://reneefrench.blogspot.com/ during pre-commit checks in GitHub Actions.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Summary
Retry Markdown link checks when the endpoint responds with HTTP 429.
Background & Motivation
The http://reneefrench.blogspot.com/ site returns HTTP 429 frequently, leading to failed pre-commit checks when run in the Github Actions runners. The markdown-link-check tool supports retrying after an HTTP 429, automatically waiting until the time specified by the "retry-after" HTTP header. See the usage docs for details.