Skip to content

GODRIVER-3331 Fix default authSource for SRV connections #1795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Sep 11, 2024

Conversation

blink1073
Copy link
Member

GODRIVER-3331

Summary

Override the default auth source from admin to $external where appropriate.

Background & Motivation

SRV connections from Atlas contain a record of authSource=admin, which we need to override for the auth mechanisms that require $external as the auth source.

@mongodb-drivers-pr-bot mongodb-drivers-pr-bot bot added the priority-3-low Low Priority PR for Review label Sep 9, 2024
Copy link
Contributor

API Change Report

No changes found!

@blink1073 blink1073 added priority-2-medium Medium Priority PR for Review and removed priority-3-low Low Priority PR for Review labels Sep 9, 2024
@blink1073 blink1073 added priority-1-high High Priority PR for Review and removed priority-2-medium Medium Priority PR for Review labels Sep 9, 2024
Copy link
Collaborator

@matthewdale matthewdale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@blink1073 blink1073 merged commit c5b9705 into mongodb:v1 Sep 11, 2024
33 checks passed
@blink1073 blink1073 deleted the GODRIVER-3331 branch September 11, 2024 17:09
blink1073 added a commit to blink1073/mongo-go-driver that referenced this pull request Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority-1-high High Priority PR for Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants