GODRIVER-3123 QE Range Protocol V2 #1723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API Change Report./mongo/optionsincompatible changesRangeOptions.Sparsity: changed from int64 to *int64 compatible changes(*RangeOptions).SetTrimFactor: added ./x/mongo/driver/mongocrypt/optionsincompatible changesExplicitRangeOptions.Sparsity: changed from int64 to *int64 compatible changesExplicitRangeOptions.TrimFactor: added |
qingyang-hu
force-pushed
the
godriver3123
branch
8 times, most recently
from
23f829d to
3aed8b9
Compare
qingyang-hu
force-pushed
the
godriver3123
branch
from
3aed8b9 to
14f2941
Compare
qingyang-hu
force-pushed
the
godriver3123
branch
2 times, most recently
from
ad04b31 to
d198255
Compare
qingyang-hu
force-pushed
the
godriver3123
branch
from
d198255 to
3f7bc45
Compare
qingyang-hu
force-pushed
the
godriver3123
branch
2 times, most recently
from
a5f3b4b to
249120b
Compare
qingyang-hu
requested review from
matthewdale,
kevinAlbs and
blink1073
and removed request for
kevinAlbs
matthewdale
reviewed
Aug 7, 2024
mongo/options/encryptoptions.go
Outdated
| @@ -81,7 +82,7 @@ func (e *EncryptOptions) SetContentionFactor(contentionFactor int64) *EncryptOpt | |||
| return e | |||
| } | |||
|
|
|||
| // SetRangeOptions specifies the options to use for explicit encryption with range. It is only valid to set if algorithm is "rangePreview". | |||
| // SetRangeOptions specifies the options to use for explicit encryption with range. It is only valid to set if algorithm is "range". | |||
There was a problem hiding this comment.
Should the algorithm be "Range", with a capital "R"?
There was a problem hiding this comment.
I was following the specs but I think you are correct. Will commit a specs PR.
mongo/options/encryptoptions.go
Outdated
| @@ -81,7 +82,7 @@ func (e *EncryptOptions) SetContentionFactor(contentionFactor int64) *EncryptOpt | |||
| return e | |||
| } | |||
|
|
|||
| // SetRangeOptions specifies the options to use for explicit encryption with range. It is only valid to set if algorithm is "rangePreview". | |||
| // SetRangeOptions specifies the options to use for explicit encryption with range. It is only valid to set if algorithm is "range". | |||
There was a problem hiding this comment.
Optional: Add a blank line here to make the "Beta" warning more visible.
Suggested change
| // SetRangeOptions specifies the options to use for explicit encryption with range. It is only valid to set if algorithm is "range". | |
| // SetRangeOptions specifies the options to use for explicit encryption with range. It is only valid to set if algorithm is "range". | |
| // |
There was a problem hiding this comment.
Should we add Range to the list of supported values for EncryptOptions.SetAlgorithm?
| return ro | ||
| } | ||
|
|
||
| // SetTrimFactor sets the range index trim factor. |
There was a problem hiding this comment.
Optional: Add a blank line here to make the "Beta" warning more visible.
Suggested change
| // SetTrimFactor sets the range index trim factor. | |
| // SetTrimFactor sets the range index trim factor. | |
| // |
There was a problem hiding this comment.
These notes will be removed in GODRIVER-3195 shortly.
blink1073
approved these changes
Aug 12, 2024
blink1073
approved these changes
Aug 12, 2024
blink1073
pushed a commit
to blink1073/mongo-go-driver
that referenced
this pull request
Aug 19, 2024
(cherry picked from commit a766876)
blink1073
added a commit
that referenced
this pull request
Aug 20, 2024
Co-authored-by: Qingyang Hu <103950869+qingyang-hu@users.noreply.github.com>
This was referenced Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-3123
GODRIVER-3279
GODRIVER-3195
Summary
RangeOpts.trimFactor.RangeOpts.sparsityoptional.rangePreviewtorange.Background & Motivation