GODRIVER-3157 Skip Serverless Proxy test that requires failpoint on hello. #1640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API Change ReportNo changes found! |
matthewdale
force-pushed
the
godriver3157-skip-sp-test
branch
from
e19ffee to
15542f0
Compare
blink1073
approved these changes
May 14, 2024
blink1073
pushed a commit
to blink1073/mongo-go-driver
that referenced
this pull request
May 14, 2024
…ello. (mongodb#1640) (cherry picked from commit 5979e93)
This was referenced Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-3157
Summary
Skip the "errors during the initial connection hello are ignored" test case when running against Serverless Proxy, which doesn't support failpoints on "hello".
Also sync the latest sdam-error-handling load balancer tests at mongodb/specifications@008d2f5 to get the corrected test description (since the skipping logic is based on test description, so would stop skipping the test if we synced that test later).
Background & Motivation
Serverless Proxy responds to "hello" directly (i.e. does not forward it to the database layer) and does not support failpoints. This test will not work on Serverless Proxy because it depends on setting a failpoint on "hello".