Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GODRIVER-3061 Support Load Balancing in Docker Container #1494

Merged
merged 24 commits into from
Dec 20, 2023
Merged

GODRIVER-3061 Support Load Balancing in Docker Container #1494

merged 24 commits into from
Dec 20, 2023

Conversation

blink1073
Copy link
Member

GODRIVER-3061

Summary

Support running the server and client separately in Docker containers, which allows us to start other services like the load balancer in parallel.

Background & Motivation

We should support testing load balanced tests using docker containers.

@blink1073 blink1073 requested a review from a team as a code owner December 12, 2023 01:40
@blink1073 blink1073 requested review from qingyang-hu and removed request for a team December 12, 2023 01:40
@blink1073 blink1073 mentioned this pull request Dec 12, 2023
Merged
@mongodb-drivers-pr-bot mongodb-drivers-pr-bot
Copy link
Contributor

API Change Report

No changes found!

qingyang-hu
qingyang-hu reviewed Dec 14, 2023
View reviewed changes
mongo/client_test.go Outdated Show resolved Hide resolved
qingyang-hu
qingyang-hu reviewed Dec 14, 2023
View reviewed changes
etc/docker_entry.sh Outdated Show resolved Hide resolved
qingyang-hu
qingyang-hu reviewed Dec 14, 2023
View reviewed changes
Copy link
Collaborator

@qingyang-hu qingyang-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except a couple of trivial suggestions.

blink1073 and others added 3 commits December 14, 2023 17:02
@blink1073 @qingyang-hu
Update mongo/client_test.go
776379a 
Co-authored-by: Qingyang Hu <103950869+qingyang-hu@users.noreply.github.com>
@blink1073 @qingyang-hu
Update mongo/with_transactions_test.go
33f5212 
Co-authored-by: Qingyang Hu <103950869+qingyang-hu@users.noreply.github.com>
@blink1073 @qingyang-hu
Update x/mongo/driver/operation/hello_test.go
c01cf6e 
Co-authored-by: Qingyang Hu <103950869+qingyang-hu@users.noreply.github.com>
blink1073 and others added 3 commits December 14, 2023 17:02
@blink1073 @qingyang-hu
Update x/mongo/driver/operation/hello_test.go
c9d8da5 
Co-authored-by: Qingyang Hu <103950869+qingyang-hu@users.noreply.github.com>
@blink1073 @qingyang-hu
Update x/mongo/driver/topology/server_test.go
3c36cd9 
Co-authored-by: Qingyang Hu <103950869+qingyang-hu@users.noreply.github.com>
@blink1073 @qingyang-hu
Update etc/docker_entry.sh
887fa7b 
Co-authored-by: Qingyang Hu <103950869+qingyang-hu@users.noreply.github.com>
blink1073
blink1073 commented Dec 14, 2023
View reviewed changes
.evergreen/config.yml Outdated Show resolved Hide resolved
qingyang-hu
qingyang-hu previously approved these changes Dec 15, 2023
View reviewed changes
@blink1073
Copy link
Member Author

evergreen retry

@blink1073 blink1073 merged commit d46f29c into mongodb:v1 Dec 20, 2023
27 of 40 checks passed
@blink1073 blink1073 deleted the standalone-docker branch December 20, 2023 12:27
blink1073 added a commit to blink1073/mongo-go-driver that referenced this pull request Dec 20, 2023
@blink1073
GODRIVER-3061 Support Load Balancing in Docker Container (mongodb#1494)
044d320 
Co-authored-by: Qingyang Hu <103950869+qingyang-hu@users.noreply.github.com>
(cherry picked from commit d46f29c)
@blink1073 blink1073 mentioned this pull request Dec 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qingyang-hu qingyang-hu qingyang-hu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blink1073 @qingyang-hu